Indicate whether a charm is subordinate

Indicate whether a charm is subordinate

The charm browser now includes a `Subordinate charm`
heading if the charm is a subordinate.

In the sidebar and full screen modes, subordinate
charms (e.g. puppet or landscape) include the
message between `Location` and `Links`.

https://code.launchpad.net/~frankban/juju-gui/browser-subordinate/+merge/177564

(do not edit description out of merge proposal)

[frankban, 2013-07-30 11:05:39]

Please take a look.

[rharding, 2013-07-30 11:17:34]

LGTM with the one note about the test below.

https://codereview.appspot.com/12058051/diff/1/test/test_browser_charm_detail...
File test/test_browser_charm_details.js (right):

https://codereview.appspot.com/12058051/diff/1/test/test_browser_charm_detail...
test/test_browser_charm_details.js:94: var data =
utils.loadFixture('data/browsercharm.json', true);
I know it's a bit of testing two things, but I think it'd be nice to add the
is_subordinate to the data here for the decoded json data. That way the charm
model is pulling the data correctly as well as it's showing in the rendered
template.

[teknico, 2013-07-30 11:33:00]

LGTM. Just template and test changes, no code ones? Nice.

[frankban, 2013-07-30 11:57:13]

*** Submitted:

Indicate whether a charm is subordinate

The charm browser now includes a `Subordinate charm`
heading if the charm is a subordinate.

In the sidebar and full screen modes, subordinate
charms (e.g. puppet or landscape) include the
message between `Location` and `Links`.

R=rharding, teknico
CC=
https://codereview.appspot.com/12058051

https://codereview.appspot.com/12058051/diff/1/test/test_browser_charm_detail...
File test/test_browser_charm_details.js (right):

https://codereview.appspot.com/12058051/diff/1/test/test_browser_charm_detail...
test/test_browser_charm_details.js:94: var data =
utils.loadFixture('data/browsercharm.json', true);
On 2013/07/30 11:17:34, rharding wrote:
> I know it's a bit of testing two things, but I think it'd be nice to add the
> is_subordinate to the data here for the decoded json data. That way the charm
> model is pulling the data correctly as well as it's showing in the rendered
> template. 

Good idea, done.

[frankban, 2013-07-30 11:59:22]

Thank you both for the reviews!