Issue 120560043: When getting content for a moved file w/ history, don't convert newlines in output of 'git show'

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 120560043: When getting content for a moved file w/ history, don't convert newlines in output of 'git show' (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 9 months ago by jrobbins (chromium)

Modified:
9 years, 1 month ago

Reviewers:
rockot, James Cook, ouhick

CC:
codereview-list_groups.google.com

Visibility:
Public.

More Reviews

Description

The normal case for getting base file content specifies universal_newlines=False, but the special case for a moved files with history was missing that keyword parameter. BUG=339068

Patch Set 1 #

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	upload.py	View		1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

jrobbins (chromium)

PTAL. This should resolve the image upload corruption problem that you sent email about earlier ...

9 years, 9 months ago (2014-08-04 22:46:38 UTC) #1

Message was sent while issue was closed.

On 2015/03/07 17:10:12, ouhick wrote:

Expand All Messages | Collapse All Messages