Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(215)

Issue 12055043: code review 12055043: go.crypto/openpgp: test that hashes are compiled in bef... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years ago by agl1
Modified:
9 years ago
Reviewers:
bradfitz
CC:
golang-dev, bradfitz
Visibility:
Public.

Description

go.crypto/openpgp: test that hashes are compiled in before using them. Previously, if Encrypt decided to use a hash function that wasn't compiled in then it would panic.

Patch Set 1 : diff -r 9c36e9eca3b5 https://code.google.com/p/go.crypto/ #

Patch Set 2 : diff -r 9c36e9eca3b5 https://code.google.com/p/go.crypto/ #

Patch Set 3 : diff -r 9c36e9eca3b5 https://code.google.com/p/go.crypto/ #

Patch Set 4 : diff -r 9c36e9eca3b5 https://code.google.com/p/go.crypto/ #

Patch Set 5 : diff -r 9c36e9eca3b5 https://code.google.com/p/go.crypto/ #

Total comments: 2

Patch Set 6 : diff -r 9c36e9eca3b5 https://code.google.com/p/go.crypto/ #

Patch Set 7 : diff -r 9c36e9eca3b5 https://code.google.com/p/go.crypto/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -14 lines) Patch
M openpgp/s2k/s2k.go View 1 2 3 4 5 2 chunks +20 lines, -7 lines 0 comments Download
M openpgp/write.go View 1 2 3 4 5 1 chunk +23 lines, -7 lines 0 comments Download

Messages

Total messages: 7
agl1
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.crypto/
9 years ago (2013-08-05 15:18:35 UTC) #1
bradfitz
LGTM But pretty weak error message. "Wanted hash function 7 in this case" => Seven? ...
9 years ago (2013-08-05 15:20:26 UTC) #2
agl1
On 2013/08/05 15:20:26, bradfitz wrote: > LGTM > > But pretty weak error message. "Wanted ...
9 years ago (2013-08-05 16:52:30 UTC) #3
bradfitz
https://codereview.appspot.com/12055043/diff/14002/openpgp/s2k/s2k.go File openpgp/s2k/s2k.go (right): https://codereview.appspot.com/12055043/diff/14002/openpgp/s2k/s2k.go#newcode177 openpgp/s2k/s2k.go:177: // given OpenPGP hash id, or panics if id ...
9 years ago (2013-08-05 16:57:51 UTC) #4
agl1
https://codereview.appspot.com/12055043/diff/14002/openpgp/s2k/s2k.go File openpgp/s2k/s2k.go (right): https://codereview.appspot.com/12055043/diff/14002/openpgp/s2k/s2k.go#newcode177 openpgp/s2k/s2k.go:177: // given OpenPGP hash id, or panics if id ...
9 years ago (2013-08-05 18:19:15 UTC) #5
bradfitz
LGTM On Mon, Aug 5, 2013 at 11:19 AM, <agl@golang.org> wrote: > > https://codereview.appspot.**com/12055043/diff/14002/**openpgp/s2k/s2k.go<https://codereview.appspot.com/12055043/diff/14002/openpgp/s2k/s2k.go> > ...
9 years ago (2013-08-05 18:21:30 UTC) #6
agl1
9 years ago (2013-08-05 18:23:08 UTC) #7
*** Submitted as
https://code.google.com/p/go/source/detail?r=1747226a2f43&repo=crypto ***

go.crypto/openpgp: test that hashes are compiled in before using them.

Previously, if Encrypt decided to use a hash function that wasn't
compiled in then it would panic.

R=golang-dev, bradfitz
CC=golang-dev
https://codereview.appspot.com/12055043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b