Issue 12052043: code review 12052043: runtime: fix arm build

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 12052043: code review 12052043: runtime: fix arm build (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 4 months ago by dvyukov

Modified:
12 years, 4 months ago

Reviewers:
rsc

CC:
golang-dev, rsc

Visibility:
Public.

Description

runtime: fix arm build The current failure is: fatal error: runtime: stack split during syscall goroutine 2 [stack split]: _addv(0xb6fa0f28, 0xd0a5112e, 0x13156d6e, 0xf8475800, 0xd) /usr/local/go/src/pkg/runtime/vlrt_arm.c:66 fp=0xb6fa0ef8 notetsleep(0xb6fa0f9c, 0xf8475800, 0xd, 0x0, 0x0, ...) /usr/local/go/src/pkg/runtime/lock_futex.c:156 +0xd0 fp=0xb6fa0f18 runtime.notetsleepg(0xb6fa0f9c, 0xf8475800, 0xd) /usr/local/go/src/pkg/runtime/lock_futex.c:197 +0x74 fp=0xb6fa0f3c

Patch Set 1 #

Patch Set 2 : diff -r 228f08ed12f7 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 3 : diff -r 228f08ed12f7 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 4 : diff -r 228f08ed12f7 https://dvyukov%40google.com@code.google.com/p/go/ #

Created: 12 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	src/pkg/runtime/vlop_arm.s	View	1	1 chunk	+1 line, -1 line	0 comments	Download
	M	src/pkg/runtime/vlrt_arm.c	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

dvyukov

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://dvyukov%40google.com@code.google.com/p/go/

12 years, 4 months ago (2013-07-29 19:36:46 UTC) #1

dvyukov

12 years, 4 months ago (2013-07-29 19:41:15 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=fb4878194fc7 ***

runtime: fix arm build

The current failure is:
fatal error: runtime: stack split during syscall
goroutine 2 [stack split]:
_addv(0xb6fa0f28, 0xd0a5112e, 0x13156d6e, 0xf8475800, 0xd)
        /usr/local/go/src/pkg/runtime/vlrt_arm.c:66 fp=0xb6fa0ef8
notetsleep(0xb6fa0f9c, 0xf8475800, 0xd, 0x0, 0x0, ...)
        /usr/local/go/src/pkg/runtime/lock_futex.c:156 +0xd0 fp=0xb6fa0f18
runtime.notetsleepg(0xb6fa0f9c, 0xf8475800, 0xd)
        /usr/local/go/src/pkg/runtime/lock_futex.c:197 +0x74 fp=0xb6fa0f3c

R=golang-dev, rsc
CC=golang-dev
https://codereview.appspot.com/12052043

Expand All Messages | Collapse All Messages