Impl destroy ghost and service

Impl destroy ghost and service

This adds the destroy ghost and destroy service functionality
to match the V11 mockups. I took some engineer-license and
implemented a confirmation dialogue as well.

https://code.launchpad.net/~hatch/juju-gui/deletable-ghost/+merge/177710

(do not edit description out of merge proposal)

[jeff.pihach, 2013-07-30 22:37:44]

Please take a look.

[benjamin.saller, 2013-07-30 23:33:23]

LGTM

I'd like to see the one method below gets its plurality  right but thats a
minor. Thanks for this.

https://codereview.appspot.com/12050049/diff/1/app/views/environment.js
File app/views/environment.js (right):

https://codereview.appspot.com/12050049/diff/1/app/views/environment.js#newco...
app/views/environment.js:369: '*:destroyServiceInspector',
this.destroyInspectors, this);
Why are we leaping from singular to plural here. If we drop the 1 inspector
rule/check this will be not what we want I think.

https://codereview.appspot.com/12050049/diff/1/app/views/inspector.js
File app/views/inspector.js (right):

https://codereview.appspot.com/12050049/diff/1/app/views/inspector.js#newcode508
app/views/inspector.js:508: this.options.environment.topo.fire('clearState');
We should (down the road) refactor the event path to topo, there is one main
view in the app and we always care about its topology when interacting with it,
so yeah, worth fixing.

[gary.poster, 2013-07-31 00:14:11]

LGTM. Ignore my Next/Deploy complaining if you like :-)

https://codereview.appspot.com/12050049/diff/1/app/templates/ghost-config-wra...
File app/templates/ghost-config-wrapper.handlebars (right):

https://codereview.appspot.com/12050049/diff/1/app/templates/ghost-config-wra...
app/templates/ghost-config-wrapper.handlebars:11: <button
class="confirm">Next</button>
The "Next" only really makes some sense if, after success, it closes the ghost
inspector and opens the post-deployment inspector.  We don't do that yet; and
even after that change happens, I'd rather have this called "Deploy," despite
the wireframe. Luca was OK with it when we discussed.

[jeff.pihach, 2013-07-31 06:12:35]

Thanks for the reviews! Comments below and changes made.

https://codereview.appspot.com/12050049/diff/1/app/templates/ghost-config-wra...
File app/templates/ghost-config-wrapper.handlebars (right):

https://codereview.appspot.com/12050049/diff/1/app/templates/ghost-config-wra...
app/templates/ghost-config-wrapper.handlebars:11: <button
class="confirm">Next</button>
I agree, changing to Deploy

https://codereview.appspot.com/12050049/diff/1/app/views/environment.js
File app/views/environment.js (right):

https://codereview.appspot.com/12050049/diff/1/app/views/environment.js#newco...
app/views/environment.js:369: '*:destroyServiceInspector',
this.destroyInspectors, this);
Good catch, changing

https://codereview.appspot.com/12050049/diff/1/app/views/inspector.js
File app/views/inspector.js (right):

https://codereview.appspot.com/12050049/diff/1/app/views/inspector.js#newcode508
app/views/inspector.js:508: this.options.environment.topo.fire('clearState');
Agreed

[jeff.pihach, 2013-07-31 06:19:09]

*** Submitted:

Impl destroy ghost and service

This adds the destroy ghost and destroy service functionality
to match the V11 mockups. I took some engineer-license and
implemented a confirmation dialogue as well.

R=benjamin.saller, gary.poster
CC=
https://codereview.appspot.com/12050049