Issue 120500043: code review 120500043: odbc: use SQL_NTS with nil terminated strings

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 120500043: code review 120500043: odbc: use SQL_NTS with nil terminated strings (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 5 months ago by brainman

Modified:
11 years, 5 months ago

Reviewers:

CC:
brainman

Visibility:
Public.

Description

odbc: use SQL_NTS with nil terminated strings Fixes issue 46.

Patch Set 1 #

Patch Set 2 : diff -r 33765b38c026 https://code.google.com/p/odbc #

Patch Set 3 : diff -r 33765b38c026 https://code.google.com/p/odbc #

Patch Set 4 : diff -r 33765b38c026 https://code.google.com/p/odbc #

Patch Set 5 : diff -r 33765b38c026 https://code.google.com/p/odbc #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -3 lines)			Patch
	M	conn.go	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	odbcstmt.go	View		1 chunk	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

brainman

Hello brainman, I'd like you to review this change to https://code.google.com/p/odbc

11 years, 5 months ago (2014-08-04 00:37:22 UTC) #1

brainman

11 years, 5 months ago (2014-08-05 02:41:58 UTC) #2

*** Submitted as https://code.google.com/p/odbc/source/detail?r=725ec3d9cede ***

odbc: use SQL_NTS with nil terminated strings

Fixes issue 46.

TBR=brainman
R=alex.brainman
CC=brainman
https://codereview.appspot.com/120500043

Expand All Messages | Collapse All Messages