Issue 12045044: code review 12045044: runtime: fix build on FreeBSD

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 12045044: code review 12045044: runtime: fix build on FreeBSD (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 11 months ago by rsc

Modified:
11 years, 10 months ago

Reviewers:
bradfitz

CC:
bradfitz, golang-dev

Visibility:
Public.

Description

runtime: fix build on FreeBSD This is what I get for being talked into a test.

Patch Set 1 #

Patch Set 2 : diff -r ead80646e9b8 https://code.google.com/p/go/ #

Patch Set 3 : diff -r d8e4fd0220d5 https://code.google.com/p/go/ #

Created: 11 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -0 lines)			Patch
	M	src/pkg/runtime/map_test.go	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello bradfitz (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/

11 years, 11 months ago (2013-07-31 03:21:05 UTC) #1

rsc

*** Submitted as https://code.google.com/p/go/source/detail?r=9df300790bba *** runtime: fix build on FreeBSD This is what I get ...

11 years, 11 months ago (2013-07-31 03:21:11 UTC) #2

bradfitz

11 years, 10 months ago (2013-07-31 15:48:30 UTC) #3

LGTM

Even though it's already been deleted.



On Tue, Jul 30, 2013 at 8:21 PM, <rsc@golang.org> wrote:

> *** Submitted as
>
https://code.google.com/p/go/**source/detail?r=9df300790bba<https://code.goog...
>
>
> runtime: fix build on FreeBSD
>
> This is what I get for being talked into a test.
>
> TBR=bradfitz
> CC=golang-dev
>
https://codereview.appspot.**com/12045044<https://codereview.appspot.com/1204...
>
>
>
https://codereview.appspot.**com/12045044/<https://codereview.appspot.com/120...
>

Expand All Messages | Collapse All Messages