code review 120440043: go-tour: handle error from ListenAndServe

go-tour: handle error from ListenAndServe

[francesc, 2014-08-01 18:05:03]

Hello adg@golang.org (cc: golang-codereviews@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go-tour

[kortschak, 2014-08-02 22:19:59]

Since you are finishing after the ListenAndServe, perhaps just wrap that call in
a log.Print() call.

On 02/08/2014, at 3:35 AM, "campoy@golang.org" <campoy@golang.org> wrote:

> Reviewers: adg,
> 
> Message:
> Hello adg@golang.org (cc: golang-codereviews@googlegroups.com),
> 
> I'd like you to review this change to
> https://code.google.com/p/go-tour
> 
> 
> Description:
> go-tour: handle error from ListenAndServe
> 
> Please review this at https://codereview.appspot.com/120440043/
> 
> Affected files (+5, -1 lines):
>  M content/methods/web-servers.go
> 
> 
> Index: content/methods/web-servers.go
> ===================================================================
> --- a/content/methods/web-servers.go
> +++ b/content/methods/web-servers.go
> @@ -4,6 +4,7 @@
> 
> import (
>    "fmt"
> +    "log"
>    "net/http"
> )
> 
> @@ -17,5 +18,8 @@
> 
> func main() {
>    var h Hello
> -    http.ListenAndServe("localhost:4000", h)
> +    err := http.ListenAndServe("localhost:4000", h)
> +    if err != nil {
> +        log.Fatal(err)
> +    }
> }
> 
> 
> -- 
> You received this message because you are subscribed to the Google Groups
"golang-codereviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
email to golang-codereviews+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.

[adg, 2014-08-04 00:56:32]

LGTM

log.Fatal is the way to go. The non-zero exit code matters.


On 3 August 2014 08:19, Dan Kortschak <dan.kortschak@adelaide.edu.au> wrote:

> Since you are finishing after the ListenAndServe, perhaps just wrap that
> call in a log.Print() call.
>
> On 02/08/2014, at 3:35 AM, "campoy@golang.org" <campoy@golang.org> wrote:
>
> > Reviewers: adg,
> >
> > Message:
> > Hello adg@golang.org (cc: golang-codereviews@googlegroups.com),
> >
> > I'd like you to review this change to
> > https://code.google.com/p/go-tour
> >
> >
> > Description:
> > go-tour: handle error from ListenAndServe
> >
> > Please review this at https://codereview.appspot.com/120440043/
> >
> > Affected files (+5, -1 lines):
> >  M content/methods/web-servers.go
> >
> >
> > Index: content/methods/web-servers.go
> > ===================================================================
> > --- a/content/methods/web-servers.go
> > +++ b/content/methods/web-servers.go
> > @@ -4,6 +4,7 @@
> >
> > import (
> >    "fmt"
> > +    "log"
> >    "net/http"
> > )
> >
> > @@ -17,5 +18,8 @@
> >
> > func main() {
> >    var h Hello
> > -    http.ListenAndServe("localhost:4000", h)
> > +    err := http.ListenAndServe("localhost:4000", h)
> > +    if err != nil {
> > +        log.Fatal(err)
> > +    }
> > }
> >
> >
> > --
> > You received this message because you are subscribed to the Google
> Groups "golang-codereviews" group.
> > To unsubscribe from this group and stop receiving emails from it, send
> an email to golang-codereviews+unsubscribe@googlegroups.com.
> > For more options, visit https://groups.google.com/d/optout.
>

[francesc, 2014-08-04 18:53:19]

*** Submitted as https://code.google.com/p/go-tour/source/detail?r=567b1fc8b836
***

go-tour: handle error from ListenAndServe

LGTM=adg
R=adg, dan.kortschak
CC=golang-codereviews
https://codereview.appspot.com/120440043