DescriptionFixes routing issues around search and charm tabs
- See bug #1205468
- See bug #1200743
Summary
-------
There are two problems. The first is that when doing some view state changes
we need to also clear the hash so that it doesn't carry around. We also clear
the charm id when doing searches in fullscreen mode. This helps the browser
app ack that there were changes in state and show the correct view.
The second issue was that clicking a tab on the fullscreen charm details after
a search causes two #bws-readme (for instance) to be added. One is before the
query string and one is after the querysting. This is caused by our double
dispatch and the fact that our routing code builds urls with query strings
after the hash of the url. This is not proper. The Y.App adds it to the end of
the url. In this way we ended up with it in both places.
Our routing code would then assume the whole #bws-readme?text=apache2 was the
hash of the url and that there was no query string. All kinds of trouble came
out of this.
Tests are added to verify the changes work as expected given our sample bad
urls.
QA
---
To QA simpler go through the steps in the two bugs and it should work as
expected. Other QA would be to verify that other usage is not adversely
effected by moving the hash to be at the end of the url while the querystring
is immediately after the path.
https://code.launchpad.net/~rharding/juju-gui/routing-issues/+merge/177401
(do not edit description out of merge proposal)
Patch Set 1 #
Total comments: 1
Patch Set 2 : Fixes routing issues around search and charm tabs #Patch Set 3 : Fixes routing issues around search and charm tabs #Patch Set 4 : Fixes routing issues around search and charm tabs #
MessagesTotal messages: 7
|