Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3116)

Issue 12031043: Removes loadByPath from charm model

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 9 months ago by j.c.sackett
Modified:
10 years, 9 months ago
Reviewers:
mp+177391, bac, rharding
Visibility:
Public.

Description

Removes loadByPath from charm model loadByPath is an option for loading a charm in Charm.sync, but we never pass a charmstore to the model's load function in the app. We do pass an environment, which is handled by a different case. -Delete the "loadByPath" case for the sync function -Remove tests regarding load/sync and the charm store -Remove tests regarding updating data from charm store based loads in endpoints (other tests cover updating data from service's and the env). https://code.launchpad.net/~jcsackett/juju-gui/remove-old-api-charm-model-2/+merge/177391 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 1

Patch Set 2 : Removes loadByPath from charm model #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -111 lines) Patch
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
M app/models/charm.js View 1 chunk +12 lines, -26 lines 0 comments Download
M test/test_endpoints.js View 1 1 chunk +0 lines, -37 lines 0 comments Download
M test/test_model.js View 3 chunks +4 lines, -47 lines 0 comments Download
M undocumented View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4
j.c.sackett
Please take a look.
10 years, 9 months ago (2013-07-29 14:43:44 UTC) #1
bac
LGTM, code removal FTW
10 years, 9 months ago (2013-07-29 16:13:34 UTC) #2
rharding
LGTM https://codereview.appspot.com/12031043/diff/1/test/test_endpoints.js File test/test_endpoints.js (left): https://codereview.appspot.com/12031043/diff/1/test/test_endpoints.js#oldcode616 test/test_endpoints.js:616: I've started to leave these. I've been asked ...
10 years, 9 months ago (2013-07-29 16:26:33 UTC) #3
j.c.sackett
10 years, 9 months ago (2013-07-29 17:04:22 UTC) #4
*** Submitted:

Removes loadByPath from charm model

loadByPath is an option for loading a charm in Charm.sync, but we never pass a
charmstore to the model's load function in the app. We do pass an environment,
which is handled by a different case.
-Delete the "loadByPath" case for the sync function
-Remove tests regarding load/sync and the charm store
-Remove tests regarding updating data from charm store based loads in endpoints
(other tests cover updating data from service's and the env).

R=bac, rharding
CC=
https://codereview.appspot.com/12031043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b