Removes remaining references to charm store

Removes remaining references to charm store

-Deletes CharmStore from app/store/charm
-Deletes test util references to CharmStore
-Removes CharmStore from the app
-Removes confusing references to charm browser as charmstore by renaming the
subapp charmbrowser where necessary
-Cleanup
-Docs
-Test updates

https://code.launchpad.net/~jcsackett/juju-gui/rip-out-old-api/+merge/177873

(do not edit description out of merge proposal)

[j.c.sackett, 2013-07-31 15:09:52]

Please take a look.

[bac, 2013-07-31 15:58:16]

Code LGTM.  A few trivial cleanups noted.

https://codereview.appspot.com/12029045/diff/1/app/models/charm.js
File app/models/charm.js (right):

https://codereview.appspot.com/12029045/diff/1/app/models/charm.js#newcode268
app/models/charm.js:268: //insepcting a service, and should be ripped out (along
with tests) when
typo: inspecting

https://codereview.appspot.com/12029045/diff/1/test/test_model.js
File test/test_model.js (right):

https://codereview.appspot.com/12029045/diff/1/test/test_model.js#newcode93
test/test_model.js:93: '~alt-bac/precise/openstack-dashboard-0/json');
a lovely test.  i bet i wrote it.  :)

https://codereview.appspot.com/12029045/diff/1/test/test_model.js#newcode517
test/test_model.js:517: // Stubbing the server callback value
Please add punctuation to comments.  

/me ducks

[benji, 2013-07-31 16:35:04]

Deleting code is a wonderful thing.  This branch looks good.  I did pick a few
style nits.

it-still-LGTM-ly y'rs,
Benji

https://codereview.appspot.com/12029045/diff/1/app/app.js
File app/app.js (right):

https://codereview.appspot.com/12029045/diff/1/app/app.js#newcode1114
app/app.js:1114: if (subapps && subapps.charmbrowser) {
Why not "charmBrowser"?

There's nothing like a good complaint about naming.

https://codereview.appspot.com/12029045/diff/1/app/app.js#newcode1339
app/app.js:1339: //should) remove this as well.
We normally have a single space after the comment marker.

We tend to use LP user names in XXX comments, that or real names.  "j.c.sackett"
is a little bit of both. :)

https://codereview.appspot.com/12029045/diff/1/app/models/charm.js
File app/models/charm.js (right):

https://codereview.appspot.com/12029045/diff/1/app/models/charm.js#newcode152
app/models/charm.js:152: //BrowserCharm; Charm wants a fully qualified url as
it's ID.
Same comments as earlier about space and name.

https://codereview.appspot.com/12029045/diff/1/app/models/charm.js#newcode209
app/models/charm.js:209: parse: function(response) {
This looks spurious.

https://codereview.appspot.com/12029045/diff/1/app/models/charm.js#newcode269
app/models/charm.js:269: //we remove that view.
Space and name.

https://codereview.appspot.com/12029045/diff/1/test/test_model.js
File test/test_model.js (right):

https://codereview.appspot.com/12029045/diff/1/test/test_model.js#newcode517
test/test_model.js:517: // Stubbing the server callback value
On 2013/07/31 15:58:16, bac wrote:
> Please add punctuation to comments.  
> 
> /me ducks

+1

/me invites bac into the punctuation fall-out shelter.

https://codereview.appspot.com/12029045/diff/1/test/test_routing.js
File test/test_routing.js (right):

https://codereview.appspot.com/12029045/diff/1/test/test_routing.js#newcode41
test/test_routing.js:41: var router = juju.Router('charmbrowser');
Are we worried at all about breaking people's stored URLs?  I kind of doubt it.

[j.c.sackett, 2013-07-31 17:04:18]

On 2013/07/31 16:35:04, benji wrote:
> Deleting code is a wonderful thing.  This branch looks good.  I did pick a few
> style nits.
> 
> it-still-LGTM-ly y'rs,
> Benji
> 
> https://codereview.appspot.com/12029045/diff/1/app/app.js
> File app/app.js (right):
> 
> https://codereview.appspot.com/12029045/diff/1/app/app.js#newcode1114
> app/app.js:1114: if (subapps && subapps.charmbrowser) {
> Why not "charmBrowser"?
> 
> There's nothing like a good complaint about naming.
> 
> https://codereview.appspot.com/12029045/diff/1/app/app.js#newcode1339
> app/app.js:1339: //should) remove this as well.
> We normally have a single space after the comment marker.
> 
> We tend to use LP user names in XXX comments, that or real names. 
"j.c.sackett"
> is a little bit of both. :)
> 
> https://codereview.appspot.com/12029045/diff/1/app/models/charm.js
> File app/models/charm.js (right):
> 
> https://codereview.appspot.com/12029045/diff/1/app/models/charm.js#newcode152
> app/models/charm.js:152: //BrowserCharm; Charm wants a fully qualified url as
> it's ID.
> Same comments as earlier about space and name.
> 
> https://codereview.appspot.com/12029045/diff/1/app/models/charm.js#newcode209
> app/models/charm.js:209: parse: function(response) {
> This looks spurious.
> 
> https://codereview.appspot.com/12029045/diff/1/app/models/charm.js#newcode269
> app/models/charm.js:269: //we remove that view.
> Space and name.
> 
> https://codereview.appspot.com/12029045/diff/1/test/test_model.js
> File test/test_model.js (right):
> 
> https://codereview.appspot.com/12029045/diff/1/test/test_model.js#newcode517
> test/test_model.js:517: // Stubbing the server callback value
> On 2013/07/31 15:58:16, bac wrote:
> > Please add punctuation to comments.  
> > 
> > /me ducks
> 
> +1
> 
> /me invites bac into the punctuation fall-out shelter.
> 
> https://codereview.appspot.com/12029045/diff/1/test/test_routing.js
> File test/test_routing.js (right):
> 
> https://codereview.appspot.com/12029045/diff/1/test/test_routing.js#newcode41
> test/test_routing.js:41: var router = juju.Router('charmbrowser');
> Are we worried at all about breaking people's stored URLs?  I kind of doubt
it.

I have no problems adding the punctuation; that wasn't my comment, just moved in
my diff. :-P I'm with you on periods.

[j.c.sackett, 2013-07-31 20:40:03]

*** Submitted:

Removes remaining references to charm store

-Deletes CharmStore from app/store/charm
-Deletes test util references to CharmStore
-Removes CharmStore from the app
-Removes confusing references to charm browser as charmstore by renaming the
subapp charmbrowser where necessary
-Cleanup
-Docs
-Test updates

R=bac, benji
CC=
https://codereview.appspot.com/12029045