code review 120280044: runtime: mark global var as NOPTR

runtime: mark global var as NOPTR

[dvyukov, 2014-07-29 08:15:05]

Hello golang-codereviews@googlegroups.com,

I'd like you to review this change to
https://dvyukov%40google.com@code.google.com/p/go/

[dave_cheney.net, 2014-07-29 08:52:33]

On 2014/07/29 08:15:05, dvyukov wrote:
> Hello mailto:golang-codereviews@googlegroups.com,
> 
> I'd like you to review this change to
> https://dvyukov%40google.com@code.google.com/p/go/

Didn't seem to help, still get

cmd/go
proggenaddsym: unaligned conservative symbol conditions: size=5 pos=868
go tool dist: FAILED: /home/dfc/go/pkg/tool/linux_arm/5l -o
/home/dfc/go/pkg/tool/linux_arm/go_bootstrap $WORK/_go_.a

[dvyukov, 2014-07-29 10:53:41]

On 2014/07/29 08:52:33, dfc wrote:
> On 2014/07/29 08:15:05, dvyukov wrote:
> > Hello mailto:golang-codereviews@googlegroups.com,
> > 
> > I'd like you to review this change to
> > https://dvyukov%40google.com@code.google.com/p/go/
> 
> Didn't seem to help, still get
> 
> cmd/go
> proggenaddsym: unaligned conservative symbol conditions: size=5 pos=868
> go tool dist: FAILED: /home/dfc/go/pkg/tool/linux_arm/5l -o
> /home/dfc/go/pkg/tool/linux_arm/go_bootstrap $WORK/_go_.a

OK, I see, it must be dataflag instead of textflag.
PTAL

GOARM=5 GOARCH=arm ./make.bash
now passes for me

[dave_cheney.net, 2014-07-29 11:13:52]

LGTM. Confirmed on linux/arm.


On Tue, Jul 29, 2014 at 8:53 PM, <dvyukov@google.com> wrote:

> On 2014/07/29 08:52:33, dfc wrote:
>
>> On 2014/07/29 08:15:05, dvyukov wrote:
>> > Hello mailto:golang-codereviews@googlegroups.com,
>> >
>> > I'd like you to review this change to
>> > https://dvyukov%40google.com@code.google.com/p/go/
>>
>
>  Didn't seem to help, still get
>>
>
>  cmd/go
>> proggenaddsym: unaligned conservative symbol conditions: size=5
>>
> pos=868
>
>> go tool dist: FAILED: /home/dfc/go/pkg/tool/linux_arm/5l -o
>> /home/dfc/go/pkg/tool/linux_arm/go_bootstrap $WORK/_go_.a
>>
>
> OK, I see, it must be dataflag instead of textflag.
> PTAL
>
> GOARM=5 GOARCH=arm ./make.bash
> now passes for me
>
>
> https://codereview.appspot.com/120280044/
>

[dvyukov, 2014-07-29 11:18:07]

*** Submitted as https://code.google.com/p/go/source/detail?r=6125ea2b1dbf ***

runtime: mark global var as NOPTR

LGTM=dave
R=golang-codereviews, dave
CC=golang-codereviews
https://codereview.appspot.com/120280044