Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(80)

Issue 120280044: code review 120280044: runtime: mark global var as NOPTR (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 7 months ago by dvyukov
Modified:
10 years, 7 months ago
Reviewers:
dave
CC:
golang-codereviews, dave_cheney.net
Visibility:
Public.

Description

runtime: mark global var as NOPTR

Patch Set 1 #

Patch Set 2 : diff -r cd8dbfda7b87 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 3 : diff -r cd8dbfda7b87 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 4 : diff -r 3dcf291a83a2 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 5 : diff -r 3dcf291a83a2 https://dvyukov%40google.com@code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M src/pkg/runtime/softfloat_arm.c View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5
dvyukov
Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://dvyukov%40google.com@code.google.com/p/go/
10 years, 7 months ago (2014-07-29 08:15:05 UTC) #1
dave_cheney.net
On 2014/07/29 08:15:05, dvyukov wrote: > Hello mailto:golang-codereviews@googlegroups.com, > > I'd like you to review ...
10 years, 7 months ago (2014-07-29 08:52:33 UTC) #2
dvyukov
On 2014/07/29 08:52:33, dfc wrote: > On 2014/07/29 08:15:05, dvyukov wrote: > > Hello mailto:golang-codereviews@googlegroups.com, ...
10 years, 7 months ago (2014-07-29 10:53:41 UTC) #3
dave_cheney.net
LGTM. Confirmed on linux/arm. On Tue, Jul 29, 2014 at 8:53 PM, <dvyukov@google.com> wrote: > ...
10 years, 7 months ago (2014-07-29 11:13:52 UTC) #4
dvyukov
10 years, 7 months ago (2014-07-29 11:18:07 UTC) #5
*** Submitted as https://code.google.com/p/go/source/detail?r=6125ea2b1dbf ***

runtime: mark global var as NOPTR

LGTM=dave
R=golang-codereviews, dave
CC=golang-codereviews
https://codereview.appspot.com/120280044
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b