Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(148)

Issue 12027043: code review 12027043: go.crypto/ssh: seed random generator, so auto port allo... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 8 months ago by hanwen-google
Modified:
10 years, 7 months ago
Reviewers:
agl1
CC:
dfc, golang-dev
Visibility:
Public.

Description

go.crypto/ssh: seed random generator, so auto port allocation is truly random.

Patch Set 1 #

Patch Set 2 : diff -r 752ba0444fdd https://code.google.com/p/go.crypto #

Patch Set 3 : diff -r 752ba0444fdd https://code.google.com/p/go.crypto #

Patch Set 4 : diff -r 752ba0444fdd https://code.google.com/p/go.crypto #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M ssh/tcpip.go View 1 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 5
hanwen-google
Hello agl@golang.org, dave@cheney.net (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.crypto
10 years, 8 months ago (2013-07-29 13:13:44 UTC) #1
hanwen-google
On 2013/07/29 13:13:44, hanwen wrote: > Hello mailto:agl@golang.org, mailto:dave@cheney.net (cc: mailto:golang-dev@googlegroups.com), > > I'd like ...
10 years, 8 months ago (2013-07-29 13:26:04 UTC) #2
agl1
*** Submitted as https://code.google.com/p/go/source/detail?r=96563f6f87f6&repo=crypto *** go.crypto/ssh: seed random generator, so auto port allocation is truly ...
10 years, 8 months ago (2013-07-29 17:09:59 UTC) #3
agl1
I though about making this randomness stronger, but it's only for a workaround of a ...
10 years, 8 months ago (2013-07-29 17:10:41 UTC) #4
hanwen-google
10 years, 7 months ago (2013-08-12 17:08:40 UTC) #5
*** Abandoned ***
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b