Issue 12025043: worker/upgrader: ChangeAgentTools

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 12025043: worker/upgrader: ChangeAgentTools

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 9 months ago by rog

Modified:
10 years, 9 months ago

Reviewers:
mue, dimitern, mp+177362

Visibility:
Public.

Description

worker/upgrader: ChangeAgentTools Copy over from cmd/jujud before we delete it from there. https://code.launchpad.net/~rogpeppe/juju-core/353-upgrader-change-agent-tools/+merge/177362 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 1

Patch Set 2 : worker/upgrader: ChangeAgentTools #

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+32 lines, -0 lines)			Patch
A	[revision details]	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	worker/upgrader/upgrader.go	View	1	1 chunk	+12 lines, -0 lines	0 comments	Download
M	worker/upgrader/upgrader_test.go	View		1 chunk	+18 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

dimitern

LGTM with a suggestion. https://codereview.appspot.com/12025043/diff/1/worker/upgrader/upgrader.go File worker/upgrader/upgrader.go (right): https://codereview.appspot.com/12025043/diff/1/worker/upgrader/upgrader.go#newcode48 worker/upgrader/upgrader.go:48: logger.Infof("upgrader upgraded from %v to ...

10 years, 9 months ago (2013-07-29 11:10:21 UTC) #2

mue

10 years, 9 months ago (2013-07-30 07:50:19 UTC) #4

Code LGTM, but binding an action to an error looks somehow strange to me.

Expand All Messages | Collapse All Messages