Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(33)

Issue 120190044: code review 120190044: runtime: convert slice operations to Go. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 7 months ago by khr
Modified:
10 years, 7 months ago
Reviewers:
gobot, khr1, dvyukov, bradfitz
CC:
golang-codereviews, bradfitz, dvyukov
Visibility:
Public.

Description

runtime: convert slice operations to Go.

Patch Set 1 #

Patch Set 2 : diff -r c8059ac4e0ec https://khr%40golang.org@code.google.com/p/go/ #

Patch Set 3 : diff -r b3d45fe62d73 https://khr%40golang.org@code.google.com/p/go/ #

Patch Set 4 : diff -r b3d45fe62d73 https://khr%40golang.org@code.google.com/p/go/ #

Patch Set 5 : diff -r b3d45fe62d73 https://khr%40golang.org@code.google.com/p/go/ #

Patch Set 6 : diff -r 676e083d0f09 https://khr%40golang.org@code.google.com/p/go/ #

Patch Set 7 : diff -r 676e083d0f09 https://khr%40golang.org@code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+164 lines, -182 lines) Patch
M src/cmd/api/goapi.go View 1 chunk +1 line, -1 line 0 comments Download
M src/cmd/gc/builtin.c View 1 chunk +1 line, -1 line 0 comments Download
M src/cmd/gc/runtime.go View 1 chunk +1 line, -1 line 0 comments Download
M src/cmd/gc/walk.c View 2 chunks +2 lines, -2 lines 0 comments Download
M src/pkg/runtime/alg.goc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/pkg/runtime/malloc.go View 1 chunk +6 lines, -0 lines 0 comments Download
A src/pkg/runtime/slice.c View 1 chunk +27 lines, -0 lines 0 comments Download
M src/pkg/runtime/slice.go View 1 chunk +121 lines, -175 lines 0 comments Download
M src/pkg/runtime/stubs.go View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 6
khr
Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://khr%40golang.org@code.google.com/p/go/
10 years, 7 months ago (2014-07-30 23:12:36 UTC) #1
bradfitz
LGTM
10 years, 7 months ago (2014-07-31 00:28:41 UTC) #2
dvyukov
LGTM
10 years, 7 months ago (2014-07-31 11:12:03 UTC) #3
khr
*** Submitted as https://code.google.com/p/go/source/detail?r=c76aa2c18a0d *** runtime: convert slice operations to Go. LGTM=bradfitz, dvyukov R=golang-codereviews, bradfitz, ...
10 years, 7 months ago (2014-07-31 19:43:57 UTC) #4
gobot
This CL appears to have broken the darwin-386-cheney builder. See http://build.golang.org/log/c03acb72ba4cbf823ecf822a74c816a2329af830
10 years, 7 months ago (2014-07-31 19:44:57 UTC) #5
khr1
10 years, 7 months ago (2014-07-31 19:49:06 UTC) #6
Real.  On it.



On Thu, Jul 31, 2014 at 12:44 PM, <gobot@golang.org> wrote:

> This CL appears to have broken the darwin-386-cheney builder.
> See http://build.golang.org/log/c03acb72ba4cbf823ecf822a74c816a2329af830
>
> https://codereview.appspot.com/120190044/
>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b