Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(214)

Issue 12006045: code review 12006045: runtime: fix code formatting (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 11 months ago by dvyukov
Modified:
11 years, 11 months ago
Reviewers:
bradfitz
CC:
rsc, golang-dev
Visibility:
Public.

Description

runtime: fix code formatting This is mainly to force another build with goroutine preemption.

Patch Set 1 #

Patch Set 2 : diff -r 01ca60884c6f https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 3 : diff -r 01ca60884c6f https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 4 : diff -r a5b5cbb9bd3d https://dvyukov%40google.com@code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M src/pkg/runtime/runtime.h View 1 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 3
dvyukov
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://dvyukov%40google.com@code.google.com/p/go/
11 years, 11 months ago (2013-07-30 19:42:29 UTC) #1
dvyukov
*** Submitted as https://code.google.com/p/go/source/detail?r=f35668002535 *** runtime: fix code formatting This is mainly to force another ...
11 years, 11 months ago (2013-07-30 19:48:26 UTC) #2
bradfitz
11 years, 11 months ago (2013-07-30 19:49:15 UTC) #3
LGTM



On Tue, Jul 30, 2013 at 12:42 PM, <dvyukov@google.com> wrote:

> Reviewers: golang-dev1,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
>
https://dvyukov%40google.com@**code.google.com/p/go/<http://40google.com@code...
>
>
> Description:
> runtime: fix code formatting
> This is mainly to force another build
> with goroutine preemption.
>
> Please review this at
https://codereview.appspot.**com/12006045/<https://codereview.appspot.com/120...
>
> Affected files:
>   M src/pkg/runtime/runtime.h
>
>
> Index: src/pkg/runtime/runtime.h
> ==============================**==============================**=======
> --- a/src/pkg/runtime/runtime.h
> +++ b/src/pkg/runtime/runtime.h
> @@ -277,8 +277,8 @@
>         int32   sig;
>         int32   writenbuf;
>         byte*   writebuf;
> -       DeferChunk      *dchunk;
> -       DeferChunk      *dchunknext;
> +       DeferChunk*     dchunk;
> +       DeferChunk*     dchunknext;
>         uintptr sigcode0;
>         uintptr sigcode1;
>         uintptr sigpc;
> @@ -323,7 +323,7 @@
>         M*      alllink;        // on allm
>         M*      schedlink;
>         uint32  machport;       // Return address for Mach IPC (OS X)
> -       MCache  *mcache;
> +       MCache* mcache;
>         int32   stackinuse;
>         uint32  stackcachepos;
>         uint32  stackcachecnt;
> @@ -353,7 +353,7 @@
>         WinCall wincall;
>  #endif
>  #ifdef GOOS_plan9
> -       int8*           notesig;
> +       int8*   notesig;
>         byte*   errstr;
>  #endif
>         SEH*    seh;
>
>
> --
>
> ---You received this message because you are subscribed to the Google
> Groups "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to
golang-dev+unsubscribe@**googlegroups.com<golang-dev%2Bunsubscribe@googlegrou...
> .
> For more options, visit
https://groups.google.com/**groups/opt_out<https://groups.google.com/groups/o...
> .
>
>
>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b