Issue 119940043: code review 119940043: cmd/5l, cmd/6l, cmd/8l: remove mkenam.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 119940043: code review 119940043: cmd/5l, cmd/6l, cmd/8l: remove mkenam. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 10 months ago by minux

Modified:
10 years, 10 months ago

Reviewers:
gobot, rsc

CC:
rsc, golang-codereviews

Visibility:
Public.

Description

cmd/5l, cmd/6l, cmd/8l: remove mkenam. Unused. cmd/dist will generate enams as liblink/anames[568].c.

Patch Set 1 #

Patch Set 2 : diff -r f4cc6d66d10c https://code.google.com/p/go #

Patch Set 3 : diff -r f4cc6d66d10c https://code.google.com/p/go #

Patch Set 4 : diff -r 6f0ff681e5ea https://code.google.com/p/go #

Created: 10 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -135 lines)			Patch
R	src/cmd/5l/mkenam	View	1 chunk	+0 lines, -45 lines	0 comments	Download
R	src/cmd/6l/mkenam	View	1 chunk	+0 lines, -45 lines	0 comments	Download
R	src/cmd/8l/mkenam	View	1 chunk	+0 lines, -45 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

minux

Hello rsc@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go

10 years, 10 months ago (2014-07-22 04:26:00 UTC) #1

minux

*** Submitted as https://code.google.com/p/go/source/detail?r=80636dadf3dd *** cmd/5l, cmd/6l, cmd/8l: remove mkenam. Unused. cmd/dist will generate enams ...

10 years, 10 months ago (2014-07-26 21:43:14 UTC) #3

gobot

This CL appears to have broken the openbsd-386-rootbsd builder. See http://build.golang.org/log/4c051b18ad61dc85f509df505cb9691c1feb05dc

10 years, 10 months ago (2014-07-26 22:08:50 UTC) #4

minux

10 years, 10 months ago (2014-07-26 23:05:53 UTC) #5

On Sat, Jul 26, 2014 at 6:08 PM, <gobot@golang.org> wrote:

> This CL appears to have broken the openbsd-386-rootbsd builder.
> See http://build.golang.org/log/4c051b18ad61dc85f509df505cb9691c1feb05dc

runtime test timeout, unrelated.

Expand All Messages | Collapse All Messages