Issue 1199044: Un-deprecate nonpaged RestfullCollection

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 1199044: Un-deprecate nonpaged RestfullCollection

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 11 months ago by zhoresh

Modified:
13 years, 11 months ago

Reviewers:
Paul Lindner, shindig.remailer

Base URL:
http://svn.apache.org/repos/asf/shindig/trunk

Visibility:
Public.

Description

Add back the constructor which is just a helper constructor to create RestfullCollection without paging.

Patch Set 1 #

Total comments: 1

Created: 13 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -0 lines)			Patch
		java/common/src/main/java/org/apache/shindig/protocol/RestfulCollection.java	View		1 chunk	+4 lines, -0 lines	1 comment	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Paul Lindner

http://codereview.appspot.com/1199044/diff/1/2 File java/common/src/main/java/org/apache/shindig/protocol/RestfulCollection.java (left): http://codereview.appspot.com/1199044/diff/1/2#oldcode62 java/common/src/main/java/org/apache/shindig/protocol/RestfulCollection.java:62: maybe add some javadoc here.. Add warnings about not ...

13 years, 11 months ago (2010-05-15 06:35:24 UTC) #2

zhoresh

13 years, 11 months ago (2010-05-15 15:59:13 UTC) #3

On 2010/05/15 06:35:24, Paul Lindner wrote:
> http://codereview.appspot.com/1199044/diff/1/2
> File
> java/common/src/main/java/org/apache/shindig/protocol/RestfulCollection.java
> (left):
> 
> http://codereview.appspot.com/1199044/diff/1/2#oldcode62
>
java/common/src/main/java/org/apache/shindig/protocol/RestfulCollection.java:62:
> 
> maybe add some javadoc here..  Add warnings about not using in a paginated
> context..

Javadoc added and committed r944672

Expand All Messages | Collapse All Messages