Added capability to edit acl in item acl report view itself

Added capability to edit acl in item acl report view itself

[Thomas.J.Waldmann, 2014-08-06 14:07:26]

https://codereview.appspot.com/119880046/diff/70001/MoinMoin/apps/admin/templ...
File MoinMoin/apps/admin/templates/admin/item_acl_report.html (right):

https://codereview.appspot.com/119880046/diff/70001/MoinMoin/apps/admin/templ...
MoinMoin/apps/admin/templates/admin/item_acl_report.html:18: <form
id="moin-acl-form" action="{{ url_for('admin.modify_acl',
item_name=item['fqname']) }}" method="GET">
basic rule of HTTP:

never modify data using GET, use POST for such stuff

[ajgupta93, 2014-08-09 13:33:40]

On 2014/08/06 14:07:26, Thomas.J.Waldmann wrote:
>
https://codereview.appspot.com/119880046/diff/70001/MoinMoin/apps/admin/templ...
> File MoinMoin/apps/admin/templates/admin/item_acl_report.html (right):
> 
>
https://codereview.appspot.com/119880046/diff/70001/MoinMoin/apps/admin/templ...
> MoinMoin/apps/admin/templates/admin/item_acl_report.html:18: <form
> id="moin-acl-form" action="{{ url_for('admin.modify_acl',
> item_name=item['fqname']) }}" method="GET">
> basic rule of HTTP:
> 
> never modify data using GET, use POST for such stuff

Done

[Thomas.J.Waldmann, 2014-08-09 17:19:36]

https://codereview.appspot.com/119880046/diff/90001/MoinMoin/apps/admin/templ...
File MoinMoin/apps/admin/templates/admin/item_acl_report.html (right):

https://codereview.appspot.com/119880046/diff/90001/MoinMoin/apps/admin/templ...
MoinMoin/apps/admin/templates/admin/item_acl_report.html:15: <td><a href="{{
url_for('frontend.show_item', item_name=item['fqname']) }}">{% if item['name']
%}{{ item['name'] | join(', ') }}{% else %}{{ _("Item Id") }}: {{ item['itemid']
}}{% endif %}</a></td>
maybe split this into multiple lines so it is better readable

https://codereview.appspot.com/119880046/diff/90001/MoinMoin/apps/admin/templ...
MoinMoin/apps/admin/templates/admin/item_acl_report.html:20: <input
type="submit"  value="{{ _("Modify ACL") }}" />
remove one of the 2 blanks

https://codereview.appspot.com/119880046/diff/90001/MoinMoin/apps/admin/views.py
File MoinMoin/apps/admin/views.py (right):

https://codereview.appspot.com/119880046/diff/90001/MoinMoin/apps/admin/views...
MoinMoin/apps/admin/views.py:326: acl_default = False
acl_default = item_acl is None

https://codereview.appspot.com/119880046/diff/90001/MoinMoin/apps/admin/views...
MoinMoin/apps/admin/views.py:328: if item_acl is None:
if acl_default:

https://codereview.appspot.com/119880046/diff/90001/MoinMoin/apps/admin/views...
MoinMoin/apps/admin/views.py:330: if item_namespace == namespace or
item_namespace == 'userprofiles' and namespace == 'userprofiles/':
this somehow looks like either being a bug or being made necessary by a bug
somewhere else.

there is nothing special with the userprofiles namespace, thus such code should
not be needed.

https://codereview.appspot.com/119880046/diff/90001/MoinMoin/apps/admin/views...
MoinMoin/apps/admin/views.py:332: acl_default = True
remove this line

https://codereview.appspot.com/119880046/diff/90001/MoinMoin/apps/admin/views...
MoinMoin/apps/admin/views.py:383: new_acl = request.form.get(fqname.value)
why fqname.value?

https://codereview.appspot.com/119880046/diff/90001/MoinMoin/apps/admin/views...
MoinMoin/apps/admin/views.py:384: meta.update({'acl': new_acl})
meta[ACL] = new_acl

[ajgupta93, 2014-08-10 06:17:49]

https://codereview.appspot.com/119880046/diff/90001/MoinMoin/apps/admin/templ...
File MoinMoin/apps/admin/templates/admin/item_acl_report.html (right):

https://codereview.appspot.com/119880046/diff/90001/MoinMoin/apps/admin/templ...
MoinMoin/apps/admin/templates/admin/item_acl_report.html:15: <td><a href="{{
url_for('frontend.show_item', item_name=item['fqname']) }}">{% if item['name']
%}{{ item['name'] | join(', ') }}{% else %}{{ _("Item Id") }}: {{ item['itemid']
}}{% endif %}</a></td>
On 2014/08/09 17:19:35, Thomas.J.Waldmann wrote:
> maybe split this into multiple lines so it is better readable

Done.

https://codereview.appspot.com/119880046/diff/90001/MoinMoin/apps/admin/templ...
MoinMoin/apps/admin/templates/admin/item_acl_report.html:20: <input
type="submit"  value="{{ _("Modify ACL") }}" />
On 2014/08/09 17:19:36, Thomas.J.Waldmann wrote:
> remove one of the 2 blanks

Done.

https://codereview.appspot.com/119880046/diff/90001/MoinMoin/apps/admin/views.py
File MoinMoin/apps/admin/views.py (right):

https://codereview.appspot.com/119880046/diff/90001/MoinMoin/apps/admin/views...
MoinMoin/apps/admin/views.py:326: acl_default = False
On 2014/08/09 17:19:36, Thomas.J.Waldmann wrote:
> acl_default = item_acl is None

Done.

https://codereview.appspot.com/119880046/diff/90001/MoinMoin/apps/admin/views...
MoinMoin/apps/admin/views.py:328: if item_acl is None:
On 2014/08/09 17:19:36, Thomas.J.Waldmann wrote:
> if acl_default:

Done.

https://codereview.appspot.com/119880046/diff/90001/MoinMoin/apps/admin/views...
MoinMoin/apps/admin/views.py:330: if item_namespace == namespace or
item_namespace == 'userprofiles' and namespace == 'userprofiles/':
On 2014/08/09 17:19:36, Thomas.J.Waldmann wrote:
> this somehow looks like either being a bug or being made necessary by a bug
> somewhere else.
> 
> there is nothing special with the userprofiles namespace, thus such code
should
> not be needed.

Yeah my fault. Misunderstood something.

https://codereview.appspot.com/119880046/diff/90001/MoinMoin/apps/admin/views...
MoinMoin/apps/admin/views.py:332: acl_default = True
On 2014/08/09 17:19:36, Thomas.J.Waldmann wrote:
> remove this line

Done.

https://codereview.appspot.com/119880046/diff/90001/MoinMoin/apps/admin/views...
MoinMoin/apps/admin/views.py:383: new_acl = request.form.get(fqname.value)
On 2014/08/09 17:19:36, Thomas.J.Waldmann wrote:
> why fqname.value?

Because the name of the text field (acl string) whose value i am retreiving is
the fqname.value of the item, in order to make each of the textboxes unique.

https://codereview.appspot.com/119880046/diff/90001/MoinMoin/apps/admin/views...
MoinMoin/apps/admin/views.py:384: meta.update({'acl': new_acl})
On 2014/08/09 17:19:36, Thomas.J.Waldmann wrote:
> meta[ACL] = new_acl

Done.

[RogerHaase, 2014-08-15 15:02:27]

looks OK, tests OK, commit