Issue 11983043: code review 11983043: freetype/truetype: function call opcodes.

Issue 11983043: code review 11983043: freetype/truetype: function call opcodes. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 5 months ago by nigeltao

Modified:
11 years, 4 months ago

Reviewers:
bsiegert

CC:
bsiegert, golang-dev

Visibility:
Public.

Description

freetype/truetype: function call opcodes.

Patch Set 2 : diff -r 15b6d4e04151 https://code.google.com/p/freetype-go #

Patch Set 3 : diff -r 15b6d4e04151 https://code.google.com/p/freetype-go #

Total comments: 6

Patch Set 4 : diff -r 15b6d4e04151 https://code.google.com/p/freetype-go #

Patch Set 5 : diff -r 15b6d4e04151 https://code.google.com/p/freetype-go #

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+227 lines, -46 lines)			Patch
M	freetype/truetype/glyph.go	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	freetype/truetype/hint.go	View	1 2 3	8 chunks	+153 lines, -28 lines	0 comments	Download
M	freetype/truetype/hint_test.go	View	1	4 chunks	+57 lines, -11 lines	0 comments	Download
M	freetype/truetype/opcodes.go	View	1	2 chunks	+5 lines, -5 lines	0 comments	Download
M	freetype/truetype/truetype.go	View	1	3 chunks	+9 lines, -2 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

nigeltao

Hello bsiegert@gmail.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/freetype-go

11 years, 5 months ago (2013-07-28 09:25:45 UTC) #1

bsiegert

https://codereview.appspot.com/11983043/diff/6001/freetype/truetype/hint.go File freetype/truetype/hint.go (right): https://codereview.appspot.com/11983043/diff/6001/freetype/truetype/hint.go#newcode16 freetype/truetype/hint.go:16: type function struct { Why not use a data ...

11 years, 4 months ago (2013-07-28 13:57:24 UTC) #2

nigeltao

11 years, 4 months ago (2013-07-29 12:50:02 UTC) #3

nigeltao

11 years, 4 months ago (2013-07-30 09:21:05 UTC) #5

*** Submitted as
https://code.google.com/p/freetype-go/source/detail?r=50ad5fe0a301 ***

freetype/truetype: function call opcodes.

R=bsiegert
CC=golang-dev
https://codereview.appspot.com/11983043

Expand All Messages | Collapse All Messages