code review 11983043: freetype/truetype: function call opcodes.

freetype/truetype: function call opcodes.

[nigeltao, 2013-07-28 09:25:45]

Hello bsiegert@gmail.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/freetype-go

[bsiegert, 2013-07-28 13:57:24]

https://codereview.appspot.com/11983043/diff/6001/freetype/truetype/hint.go
File freetype/truetype/hint.go (right):

https://codereview.appspot.com/11983043/diff/6001/freetype/truetype/hint.go#n...
freetype/truetype/hint.go:16: type function struct {
Why not use a data structure of the kind

type functions map[int32][]byte

?

https://codereview.appspot.com/11983043/diff/6001/freetype/truetype/hint.go#n...
freetype/truetype/hint.go:550: case opPUSHB000, opPUSHB001, opPUSHB010,
opPUSHB011,
Why the linebreak? Remove?

https://codereview.appspot.com/11983043/diff/6001/freetype/truetype/hint.go#n...
freetype/truetype/hint.go:556: case opPUSHW000, opPUSHW001, opPUSHW010,
opPUSHW011,
ditto

https://codereview.appspot.com/11983043/diff/6001/freetype/truetype/hint.go#n...
freetype/truetype/hint.go:660: case opPUSHB000, opPUSHB001, opPUSHB010,
opPUSHB011,
ditto here and below

[nigeltao, 2013-07-29 12:50:02]

https://codereview.appspot.com/11983043/diff/6001/freetype/truetype/hint.go
File freetype/truetype/hint.go (right):

https://codereview.appspot.com/11983043/diff/6001/freetype/truetype/hint.go#n...
freetype/truetype/hint.go:16: type function struct {
On 2013/07/28 13:57:25, bsiegert wrote:
> Why not use a data structure of the kind
> 
> type functions map[int32][]byte
> 
> ?

Done.

https://codereview.appspot.com/11983043/diff/6001/freetype/truetype/hint.go#n...
freetype/truetype/hint.go:550: case opPUSHB000, opPUSHB001, opPUSHB010,
opPUSHB011,
On 2013/07/28 13:57:25, bsiegert wrote:
> Why the linebreak? Remove?

I think it reads better with a line break.

[bsiegert, 2013-07-29 12:52:53]

LGTM

[nigeltao, 2013-07-30 09:21:05]

*** Submitted as
https://code.google.com/p/freetype-go/source/detail?r=50ad5fe0a301 ***

freetype/truetype: function call opcodes.

R=bsiegert
CC=golang-dev
https://codereview.appspot.com/11983043