code review 11978043: main: Add a BigQuery example to google-api-go-client.

main: Add a BigQuery example to google-api-go-client.

This example illustrates doing loading of objects stored in
Google Cloud Storage into BigQuery dataset tables.

[garrick, 2013-07-28 03:16:23]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/google-api-go-client/

[adg, 2013-07-30 06:19:45]

https://codereview.appspot.com/11978043/diff/9001/examples/main.go
File examples/main.go (right):

https://codereview.appspot.com/11978043/diff/9001/examples/main.go#newcode5
examples/main.go:5: // This file is the same as the go-api-demo main.go with the
modification
is it?

[garrick, 2013-07-30 15:17:21]

https://codereview.appspot.com/11978043/diff/9001/examples/main.go
File examples/main.go (right):

https://codereview.appspot.com/11978043/diff/9001/examples/main.go#newcode5
examples/main.go:5: // This file is the same as the go-api-demo main.go with the
modification
On 2013/07/30 06:19:45, adg wrote:
> is it?

removed. also updated below to include client id in hash/remove from cache file
name.

[adg, 2013-07-31 06:31:02]

https://codereview.appspot.com/11978043/diff/20001/examples/bigquery.go
File examples/bigquery.go (right):

https://codereview.appspot.com/11978043/diff/20001/examples/bigquery.go#newco...
examples/bigquery.go:301: if job.Status.State == JobStatusDone {
if job.Status.State != JobStatusDone {
  jobq.PushBack(job)
  continue
}
and unindent the rest

https://codereview.appspot.com/11978043/diff/20001/examples/main.go
File examples/main.go (right):

https://codereview.appspot.com/11978043/diff/20001/examples/main.go#newcode159
examples/main.go:159: randState := fmt.Sprintf("st%d", time.Now().UnixNano())
Why?

[garrick, 2013-08-05 17:50:27]

https://codereview.appspot.com/11978043/diff/20001/examples/bigquery.go
File examples/bigquery.go (right):

https://codereview.appspot.com/11978043/diff/20001/examples/bigquery.go#newco...
examples/bigquery.go:301: if job.Status.State == JobStatusDone {
On 2013/07/31 06:31:02, adg wrote:
> if job.Status.State != JobStatusDone {
>   jobq.PushBack(job)
>   continue
> }
> and unindent the rest

Done.

https://codereview.appspot.com/11978043/diff/20001/examples/main.go
File examples/main.go (right):

https://codereview.appspot.com/11978043/diff/20001/examples/main.go#newcode159
examples/main.go:159: randState := fmt.Sprintf("st%d", time.Now().UnixNano())
On 2013/07/31 06:31:02, adg wrote:
> Why?
govet flagged this - presumably for formatting a struct with %d

[adg, 2013-08-15 04:05:11]

LGTM

[adg, 2013-08-15 04:13:57]

*** Submitted as
https://code.google.com/p/google-api-go-client/source/detail?r=112f598ccd42 ***

main: Add a BigQuery example to google-api-go-client.

This example illustrates doing loading of objects stored in
Google Cloud Storage into BigQuery dataset tables.

R=golang-dev, adg
CC=golang-dev
https://codereview.appspot.com/11978043

Committer: Andrew Gerrand <adg@golang.org>