Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(958)

Issue 11967047: code review 11967047: go.talks: add support for mouse wheel interaction on th... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 8 months ago by francesc
Modified:
10 years, 8 months ago
Reviewers:
r, adg
CC:
adg, golang-dev
Visibility:
Public.

Description

go.talks: add support for mouse wheel interaction on the slides.

Patch Set 1 #

Patch Set 2 : code review 11967047: go.talks: add support for mouse wheel interaction on th... #

Patch Set 3 : diff -r 4ff71e863773 https://code.google.com/p/go.talks #

Patch Set 4 : diff -r 4ff71e863773 https://code.google.com/p/go.talks #

Patch Set 5 : diff -r 4ff71e863773 https://code.google.com/p/go.talks #

Patch Set 6 : diff -r 4ff71e863773 https://code.google.com/p/go.talks #

Patch Set 7 : diff -r 4ff71e863773 https://code.google.com/p/go.talks #

Patch Set 8 : diff -r f86cc7f28f12 https://code.google.com/p/go.talks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M present/static/slides.js View 1 2 3 4 5 6 2 chunks +12 lines, -0 lines 0 comments Download

Messages

Total messages: 8
francesc
Hello adg@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.talks
10 years, 8 months ago (2013-07-31 23:05:52 UTC) #1
adg
LGTM
10 years, 8 months ago (2013-07-31 23:29:14 UTC) #2
francesc
*** Submitted as https://code.google.com/p/go/source/detail?r=d44f1df51f4d&repo=talks *** go.talks: add support for mouse wheel interaction on the slides. ...
10 years, 8 months ago (2013-07-31 23:40:20 UTC) #3
r
Please don't do this, at least if I understand its effect. It seems to me ...
10 years, 8 months ago (2013-08-01 00:43:37 UTC) #4
francesc
IMHO the fact that slides are moving left is just a visual artifact without too ...
10 years, 8 months ago (2013-08-01 01:41:16 UTC) #5
r
thanks. visually, it moves left. scroll down moving left is ok *if* scroll left almost ...
10 years, 8 months ago (2013-08-01 01:44:00 UTC) #6
r
s/almost/also/ having a rough morning i guess. On Thu, Aug 1, 2013 at 11:43 AM, ...
10 years, 8 months ago (2013-08-01 01:44:11 UTC) #7
francesc
10 years, 8 months ago (2013-08-01 01:49:29 UTC) #8
No problem, I can implement that easily.

So, scrolling down or left, moves the slides to the left.

I'd like to handle the touchpad scrolling events, but they're ridiculously
complicated to handle correctly as far as I've seen.


On Wed, Jul 31, 2013 at 6:43 PM, Rob Pike <r@golang.org> wrote:

> s/almost/also/
>
> having a rough morning i guess.
>
>
> On Thu, Aug 1, 2013 at 11:43 AM, Rob Pike <r@golang.org> wrote:
>
>> thanks.
>>
>> visually, it moves left. scroll down moving left is ok *if* scroll left
>> almost moves left.
>>
>
>


-- 
--
Francesc
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b