code review 11967047: go.talks: add support for mouse wheel interaction on th...

go.talks: add support for mouse wheel interaction on the slides.

[francesc, 2013-07-31 23:05:52]

Hello adg@golang.org (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go.talks

[adg, 2013-07-31 23:29:14]

LGTM

[francesc, 2013-07-31 23:40:20]

*** Submitted as
https://code.google.com/p/go/source/detail?r=d44f1df51f4d&repo=talks ***

go.talks: add support for mouse wheel interaction on the slides.

R=adg
CC=golang-dev
https://codereview.appspot.com/11967047

[r, 2013-08-01 00:43:37]

Please don't do this, at least if I understand its effect. It seems to me
that it means an "up" event moves the slides left. It's wrong to
reinterpret scrolling that way. If I go up, it should mean "up". If I go
left, it should mean "left".

Retract and rethink.

-rob

[francesc, 2013-08-01 01:41:16]

IMHO the fact that slides are moving left is just a visual artifact without
too much importance.

In a long document, you scroll down to access the content following the
current viewport.

Following that idea, scrolling down to access the next slides makes sense
to me.

While we reach an agreement, I undid it:
https://codereview.appspot.com/12217043

On Wed, Jul 31, 2013 at 5:43 PM, Rob Pike <r@golang.org> wrote:

> Please don't do this, at least if I understand its effect. It seems to me
> that it means an "up" event moves the slides left. It's wrong to
> reinterpret scrolling that way. If I go up, it should mean "up". If I go
> left, it should mean "left".
>
> Retract and rethink.
>
> -rob
>
>


-- 
--
Francesc

[r, 2013-08-01 01:44:00]

thanks.

visually, it moves left. scroll down moving left is ok *if* scroll left
almost moves left.

[r, 2013-08-01 01:44:11]

s/almost/also/

having a rough morning i guess.


On Thu, Aug 1, 2013 at 11:43 AM, Rob Pike <r@golang.org> wrote:

> thanks.
>
> visually, it moves left. scroll down moving left is ok *if* scroll left
> almost moves left.
>

[francesc, 2013-08-01 01:49:29]

No problem, I can implement that easily.

So, scrolling down or left, moves the slides to the left.

I'd like to handle the touchpad scrolling events, but they're ridiculously
complicated to handle correctly as far as I've seen.


On Wed, Jul 31, 2013 at 6:43 PM, Rob Pike <r@golang.org> wrote:

> s/almost/also/
>
> having a rough morning i guess.
>
>
> On Thu, Aug 1, 2013 at 11:43 AM, Rob Pike <r@golang.org> wrote:
>
>> thanks.
>>
>> visually, it moves left. scroll down moving left is ok *if* scroll left
>> almost moves left.
>>
>
>


-- 
--
Francesc