Fix boolean export from gui.

Fix boolean export from gui.

This updates the js-yaml with a fix for escaping string values which are yaml 
1.1 aliases for booleans. By default js-yaml implements 1.2 which does away with 
these aliases, resulting in roundtripping issues between gui and python or golang.

https://code.launchpad.net/~hazmat/juju-gui/yaml-export-bool-redux/+merge/177263

(do not edit description out of merge proposal)

[hazmat, 2013-07-27 16:07:24]

Please take a look.

[teknico, 2013-07-29 17:03:48]

This is way too cryptic.

I had a look at the following pages:

Bad handling of strings with boolean alias values when dumping
<https://github.com/nodeca/js-yaml/issues/85>

Escape boolean alias strings to play nice with yaml 1.1 implementations
<https://github.com/nodeca/js-yaml/pull/86>

<https://github.com/nodeca/js-yaml/blob/master/lib/js-yaml/dumper.js#L155>

It is still not clear to me what the source change is, and how it produces the
changes in the minified output shown on Launchpad (the diff is not viewable here
on Rietveld).

Please add a description with the source diff and the commands to run on the
source to get the final minified output.

Also, please add the commands to reproduce the problem, and to check that the
change fixes the problem.

Thank you.

[hazmat, 2013-07-29 17:29:07]

its a one line, change should i put the diff in the comment? i can
alternatively point to my fork which has the one line change. documenting
in a minified version doesn't feel right, i can toss a doc describing into
docs alternatively.


On Mon, Jul 29, 2013 at 1:03 PM, <nicola.larosa@canonical.com> wrote:

> This is way too cryptic.
>
> I had a look at the following pages:
>
> Bad handling of strings with boolean alias values when dumping
>
<https://github.com/nodeca/js-**yaml/issues/85<https://github.com/nodeca/js-ya...
> >
>
> Escape boolean alias strings to play nice with yaml 1.1 implementations
>
<https://github.com/nodeca/js-**yaml/pull/86<https://github.com/nodeca/js-yaml...
> >
>
> <https://github.com/nodeca/js-**yaml/blob/master/lib/js-yaml/**
>
dumper.js#L155<https://github.com/nodeca/js-yaml/blob/master/lib/js-yaml/dumper.js#L155>
> >
>
> It is still not clear to me what the source change is, and how it
> produces the changes in the minified output shown on Launchpad (the diff
> is not viewable here on Rietveld).
>
> Please add a description with the source diff and the commands to run on
> the source to get the final minified output.
>
> Also, please add the commands to reproduce the problem, and to check
> that the change fixes the problem.
>
> Thank you.
>
>
https://codereview.appspot.**com/11966044/<https://codereview.appspot.com/119...
>

[benji, 2013-07-29 17:49:19]

LGTM

I would like us to think about how we manage third-party code some.  Perhaps a
manifest that lists where files were retrieved from.

We could then have a lint step that ensures all files are listed in the
manifest.

[gary.poster, 2013-07-29 17:53:46]

On 2013/07/29 17:29:07, hazmat wrote:
> its a one line, change should i put the diff in the comment? i can
> alternatively point to my fork which has the one line change. documenting
> in a minified version doesn't feel right, i can toss a doc describing into
> docs alternatively.

Hi Kapil.  Thank you again for driving this.

I'd be fine with one of two options.

(1) Start the minimized file with something like this:

/* Generated from XXX_YOUR_BRANCH_XXX with `make browserify`.
   See https://github.com/nodeca/js-yaml/issues/85 .*/

(2) Start the minimized file with this:

/* See docs/hacking.rst for source and background of this file */

Then in hacking have a new section that mentions it.

For Nicola's request for repro/qa commands, maybe just mention a charm with bool
flags that you have used for testing?

Gary

[gary.poster, 2013-07-29 18:40:24]

On 2013/07/29 17:53:46, gary.poster wrote:
> On 2013/07/29 17:29:07, hazmat wrote:
> > its a one line, change should i put the diff in the comment? i can
> > alternatively point to my fork which has the one line change. documenting
> > in a minified version doesn't feel right, i can toss a doc describing into
> > docs alternatively.
> 
> Hi Kapil.  Thank you again for driving this.
> 
> I'd be fine with one of two options.
> 
> (1) Start the minimized file with something like this:
> 
> /* Generated from XXX_YOUR_BRANCH_XXX with `make browserify`.
>    See https://github.com/nodeca/js-yaml/issues/85 .*/
> 
> (2) Start the minimized file with this:
> 
> /* See docs/hacking.rst for source and background of this file */
> 
> Then in hacking have a new section that mentions it.
> 
> For Nicola's request for repro/qa commands, maybe just mention a charm with
bool
> flags that you have used for testing?
> 
> Gary

Kapil, also, if you want to run with this to get it landed, just let us know. 
We appreciate what you've already done.

[hazmat, 2013-07-30 16:26:37]

addressed via #1. thanks


On Mon, Jul 29, 2013 at 2:40 PM, <gary.poster@canonical.com> wrote:

> On 2013/07/29 17:53:46, gary.poster wrote:
>
>> On 2013/07/29 17:29:07, hazmat wrote:
>> > its a one line, change should i put the diff in the comment? i can
>> > alternatively point to my fork which has the one line change.
>>
> documenting
>
>> > in a minified version doesn't feel right, i can toss a doc
>>
> describing into
>
>> > docs alternatively.
>>
>
>  Hi Kapil.  Thank you again for driving this.
>>
>
>  I'd be fine with one of two options.
>>
>
>  (1) Start the minimized file with something like this:
>>
>
>  /* Generated from XXX_YOUR_BRANCH_XXX with `make browserify`.
>>     See
https://github.com/nodeca/js-**yaml/issues/85<https://github.com/nodeca/js-ya...
>>
>
>  (2) Start the minimized file with this:
>>
>
>  /* See docs/hacking.rst for source and background of this file */
>>
>
>  Then in hacking have a new section that mentions it.
>>
>
>  For Nicola's request for repro/qa commands, maybe just mention a charm
>>
> with bool
>
>> flags that you have used for testing?
>>
>
>  Gary
>>
>
> Kapil, also, if you want to run with this to get it landed, just let us
> know.  We appreciate what you've already done.
>
>
https://codereview.appspot.**com/11966044/<https://codereview.appspot.com/119...
>

[hazmat, 2013-07-30 16:35:21]

*** Submitted:

Fix boolean export from gui.

This updates the js-yaml with a fix for escaping string values which are yaml 
1.1 aliases for booleans. By default js-yaml implements 1.2 which does away with

these aliases, resulting in roundtripping issues between gui and python or
golang.

R=teknico, benji, gary.poster
CC=
https://codereview.appspot.com/11966044