Issue 11963044: code review 11963044: runtime: fix arm build.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 11963044: code review 11963044: runtime: fix arm build. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 8 months ago by remyoudompheng

Modified:
11 years, 8 months ago

Reviewers:
rsc

CC:
golang-dev, rsc

Visibility:
Public.

Description

runtime: fix arm build. More functions needs to be marked as no stack split.

Patch Set 1 #

Patch Set 2 : diff -r 1c2053db3e0a https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r c632dcca98ca https://code.google.com/p/go #

Patch Set 4 : diff -r f70981e60e17 https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r f70981e60e17 https://code.google.com/p/go #

Patch Set 6 : diff -r f70981e60e17 https://code.google.com/p/go #

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -7 lines)			Patch
	M	src/pkg/runtime/vlrt_arm.c	View	1 2	4 chunks	+6 lines, -7 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

remyoudompheng

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go

11 years, 8 months ago (2013-08-01 04:29:56 UTC) #1

remyoudompheng

Hello golang-dev@googlegroups.com, rsc@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

11 years, 8 months ago (2013-08-01 05:46:42 UTC) #3

remyoudompheng

11 years, 8 months ago (2013-08-01 05:48:31 UTC) #4

*** Submitted as https://code.google.com/p/go/source/detail?r=b2f71fb7e959 ***

runtime: fix arm build.

More functions needs to be marked as no stack split.

R=golang-dev, rsc
CC=golang-dev
https://codereview.appspot.com/11963044

Expand All Messages | Collapse All Messages