Issue 1196046: Serialization of HTML5 classes for HLWK.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 1196046: Serialization of HTML5 classes for HLWK.

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 11 months ago by sauta

Modified:
13 years, 11 months ago

Reviewers:
razmyslovich, baran, Eran, viarheichyk

CC:
webdriver-mobile-eng_google.com

Base URL:
http://webkitdriver.googlecode.com/svn/trunk/

Visibility:
Public.

Patch Set 1 #

Total comments: 1

Created: 13 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -1 line)			Patch
	M	driver/src/java/org/openqa/selenium/webkit/WebKitSerializer.java	View		3 chunks	+15 lines, -1 line	1 comment	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Eran

13 years, 11 months ago (2010-05-21 10:17:31 UTC) #2

http://codereview.appspot.com/1196046/diff/1/2
File driver/src/java/org/openqa/selenium/webkit/WebKitSerializer.java (right):

http://codereview.appspot.com/1196046/diff/1/2#newcode329
driver/src/java/org/openqa/selenium/webkit/WebKitSerializer.java:329: switch
(stream.getInt()) {
Using a Map to store the mapping between integer and enum values will make this
code block more readable (instead of nested switch statements).

Expand All Messages | Collapse All Messages