Issue 11955: perlbal X-REPROXY-FILE does not work with SSL connections

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 11955: perlbal X-REPROXY-FILE does not work with SSL connections

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 3 months ago by Greg.Denton

Modified:
8 years, 4 months ago

Reviewers:

Base URL:
http://code.sixapart.com/svn/perlbal/trunk/

Visibility:
Public.

Description

Fix is to use Danga::Socket write method when socket has SSL instead of POSIX::write via Perlbal::Socket. Since my site is not in production it is not production tested but my tests run pretty heavy loads and no problem so far. Note that there are no existing test mechanisms for SSL so I couldn't write a test case (without a lot of work, that is).

Patch Set 1 #

Patch Set 2 : oops...did not diff from trunk...trying again (ignore previous patch) #

Created: 15 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+51 lines, -13 lines)			Patch
		lib/Perlbal/ClientHTTPBase.pm	View		3 chunks	+51 lines, -13 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Greg.Denton

15 years, 3 months ago (2009-01-22 00:46:09 UTC) #2

oops...did not diff from trunk...trying again (ignore previous patch)

Expand All Messages | Collapse All Messages