Issue 119530043: code review 119530043: go.tools/go/ssa/interp: some fixes to tests

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 119530043: code review 119530043: go.tools/go/ssa/interp: some fixes to tests (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 1 month ago by adonovan

Modified:
11 years, 1 month ago

Reviewers:
gri

CC:
gri, golang-codereviews

Visibility:
Public.

Description

go.tools/go/ssa/interp: some fixes to tests - Break out parts of coverage.go into more specific files. - Re-enable test of nil interface-to-interface conversion. - Update initorder test to reflect spec ambiguity and gc vs go/types variance. - Re-enable test dependent on now-fixed bug 8189 ("value,ok" yields an untyped bool)

Patch Set 1 #

Patch Set 2 : diff -r e3c39d0035bf https://code.google.com/p/go.tools #

Patch Set 3 : diff -r e3c39d0035bf https://code.google.com/p/go.tools #

Patch Set 4 : diff -r e3c39d0035bf https://code.google.com/p/go.tools #

Patch Set 5 : diff -r e3c39d0035bf98d4bb9fa3b0a6b0f114f67584d1 https://code.google.com/p/go.tools #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+293 lines, -269 lines)			Patch
M	go/ssa/interp/interp_test.go	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
A	go/ssa/interp/testdata/complit.go	View	1	1 chunk	+84 lines, -0 lines	0 comments	Download
M	go/ssa/interp/testdata/coverage.go	View	1	11 chunks	+12 lines, -269 lines	0 comments	Download
A	go/ssa/interp/testdata/defer.go	View	1	1 chunk	+53 lines, -0 lines	0 comments	Download
M	go/ssa/interp/testdata/initorder.go	View	1	2 chunks	+27 lines, -0 lines	0 comments	Download
A	go/ssa/interp/testdata/range.go	View	1	1 chunk	+55 lines, -0 lines	0 comments	Download
A	go/ssa/interp/testdata/static.go	View	1 2 3	1 chunk	+58 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

adonovan

Hello gri@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.tools

11 years, 1 month ago (2014-08-06 16:11:05 UTC) #1

adonovan

11 years, 1 month ago (2014-08-07 14:57:03 UTC) #3

*** Submitted as
https://code.google.com/p/go/source/detail?r=4565a2969cba&repo=tools ***

go.tools/go/ssa/interp: some fixes to tests

- Break out parts of coverage.go into more specific files.
- Re-enable test of nil interface-to-interface conversion.
- Update initorder test to reflect spec ambiguity and gc vs go/types variance.
- Re-enable test dependent on now-fixed bug 8189 ("value,ok" yields an untyped
bool)

LGTM=gri
R=gri
CC=golang-codereviews
https://codereview.appspot.com/119530043

Expand All Messages | Collapse All Messages