Issue 11938044: Bring D3 up to v3

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 11938044: Bring D3 up to v3

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 9 months ago by matthew.scott

Modified:
10 years, 9 months ago

Reviewers:
jeff.pihach, mp+177202

Visibility:
Public.

Description

Bring D3 up to v3 This branch brings D3 up to v3 in order to add features that could be of use to us. Recommend heavy QA - though it looks fine so far. Note that npm-shrinkwrap.json is a generated file, and will have a big diff. https://code.launchpad.net/~makyo/juju-gui/d3v3/+merge/177202 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Bring D3 up to v3 #

Patch Set 3 : Bring D3 up to v3 #

Patch Set 4 : Bring D3 up to v3 #

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+949 lines, -709 lines)			Patch
M	.bzrignore	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	Makefile	View		3 chunks	+6 lines, -6 lines	0 comments	Download
A	[revision details]	View	1 2 3	1 chunk	+2 lines, -0 lines	0 comments	Download
M	app/assets/javascripts/unscaled-pack-layout.js	View	1 2 3	2 chunks	+18 lines, -2 lines	0 comments	Download
M	app/modules-debug.js	View		1 chunk	+1 line, -1 line	0 comments	Download
M	bin/merge-files	View		1 chunk	+1 line, -1 line	0 comments	Download
M	npm-shrinkwrap.json	View		15 chunks	+918 lines, -696 lines	0 comments	Download
M	package.json	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

jeff.pihach

LGTM QA OK It might not hurt to throw a comment at the top of ...

10 years, 9 months ago (2013-07-26 18:46:27 UTC) #3

matthew.scott

10 years, 9 months ago (2013-07-26 20:48:20 UTC) #5

*** Submitted:

Bring D3 up to v3

This branch brings D3 up to v3 in order to add features that could be of use to
us.  Recommend heavy QA - though it looks fine so far.  Note that
npm-shrinkwrap.json is a generated file, and will have a big diff.

R=jeff.pihach, bac
CC=
https://codereview.appspot.com/11938044

Expand All Messages | Collapse All Messages