Keyboard Shortcuts
File
u
:
up to issue
m
:
publish + mail comments
M
:
edit review message
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
<Enter>
:
respond to / edit current comment
d
:
mark current comment as done
Issue
u
:
up to list of issues
m
:
publish + mail comments
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
#
:
close issue
Comment/message editing
<Ctrl>
+
s
or
<Ctrl>
+
Enter
:
save comment
<Esc>
:
cancel edit
Rietveld
Code Review Tool
Help
|
Bug tracker
|
Discussion group
|
Source code
|
Sign in
(307)
Issues
Repositories
Search
Open Issues
|
Closed Issues
|
All Issues
|
Sign in
with your
Google Account
to create issues and add comments
Issue
119060043
: Remove bogus missing input file from asan.gyp. (Closed)
Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 10 months ago by
chrisha
Modified:
9 years, 10 months ago
Reviewers:
Sébastien Marchand
CC:
sawbuck-changes_googlegroups.com
Base URL:
http://sawbuck.googlecode.com/svn/trunk
Visibility:
Public.
More Reviews
Description
Remove bogus missing input file from asan.gyp. BUG= R=sebmarchand@chromium.org Committed: https://code.google.com/p/sawbuck/source/detail?r=2188
Patch Set 1
#
Created:
9 years, 10 months ago
Download
[raw]
[tar.bz2]
Unified diffs
Side-by-side diffs
Delta from patch set
Stats
(
+0 lines, -1 line
)
Patch
M
syzygy/agent/asan/asan.gyp
View
1 chunk
+0 lines, -1 line
0 comments
Download
Messages
Total messages: 4
Expand All Messages
|
Collapse All Messages
chrisha
PTAL
9 years, 10 months ago (2014-07-22 18:03:11 UTC)
#1
PTAL
Sign in
to reply to this message.
Sébastien Marchand
lgtm.
9 years, 10 months ago (2014-07-22 18:04:14 UTC)
#2
lgtm.
Sign in
to reply to this message.
chrisha
Thanks, committing!
9 years, 10 months ago (2014-07-22 18:42:18 UTC)
#3
Thanks, committing!
Sign in
to reply to this message.
chrisha
Committed patchset #1 manually as r2188 (presubmit successful).
9 years, 10 months ago (2014-07-22 18:42:52 UTC)
#4
Message was sent while issue was closed.
Committed patchset #1 manually as r2188 (presubmit successful).
Sign in
to reply to this message.
Expand All Messages
|
Collapse All Messages
Issue 119060043: Remove bogus missing input file from asan.gyp. (Closed)
Created 9 years, 10 months ago by chrisha
Modified 9 years, 10 months ago
Reviewers: Sébastien Marchand
Base URL: http://sawbuck.googlecode.com/svn/trunk
Comments: 0
Recent Issues
|
This issue
This is Rietveld
f62528b