code review 119000043: liblink: more precise literal word comparison on arm

liblink: more precise literal word comparison on arm

There are fields in the Addr that do not matter for the
purpose of deciding that the same word is already
in the current literal pool. Copy only the fields that
do matter.

This came up when comparing against the Go version
because the way it is invoked doesn't copy a few fields
(like node) that are never directly used by liblink itself.

Also remove a stray print that is not well-defined in
the new liblink. (Cannot use %D outside of %P, because
%D needs the outer Prog*.)

[rsc, 2014-07-21 21:42:30]

Hello minux (cc: golang-codereviews@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go/

[minux, 2014-07-22 03:03:55]

LGTM.

https://codereview.appspot.com/119000043/diff/40001/src/liblink/asm5.c
File src/liblink/asm5.c (right):

https://codereview.appspot.com/119000043/diff/40001/src/liblink/asm5.c#newcod...
src/liblink/asm5.c:981: for(q = ctxt->blitrl; q != nil; q = q->link)	/* could
hash on t.t0.offset */
s/t0/to/??

[rsc, 2014-07-23 14:18:03]

*** Submitted as https://code.google.com/p/go/source/detail?r=48ac89af1d1b ***

liblink: more precise literal word comparison on arm

There are fields in the Addr that do not matter for the
purpose of deciding that the same word is already
in the current literal pool. Copy only the fields that
do matter.

This came up when comparing against the Go version
because the way it is invoked doesn't copy a few fields
(like node) that are never directly used by liblink itself.

Also remove a stray print that is not well-defined in
the new liblink. (Cannot use %D outside of %P, because
%D needs the outer Prog*.)

LGTM=minux
R=minux
CC=golang-codereviews
https://codereview.appspot.com/119000043