Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1965)

Issue 11893043: code review 11893043: goprotobuf: Switch to using protobuf-2.5.0 as the baseline. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 9 months ago by dsymonds
Modified:
10 years, 9 months ago
Reviewers:
r
CC:
r, golang-dev
Visibility:
Public.

Description

goprotobuf: Switch to using protobuf-2.5.0 as the baseline. Regenerating descriptor.pb.go also lays the path for using SourceCodeInfo in the code generator.

Patch Set 1 #

Patch Set 2 : diff -r 1e002248bc7f https://code.google.com/p/goprotobuf #

Patch Set 3 : diff -r 1e002248bc7f https://code.google.com/p/goprotobuf #

Patch Set 4 : diff -r 1e002248bc7f https://code.google.com/p/goprotobuf #

Unified diffs Side-by-side diffs Delta from patch set Stats (+137 lines, -19 lines) Patch
M protoc-gen-go/descriptor/Makefile View 1 1 chunk +2 lines, -2 lines 0 comments Download
M protoc-gen-go/descriptor/descriptor.pb.go View 1 15 chunks +130 lines, -13 lines 0 comments Download
M protoc-gen-go/plugin/Makefile View 1 1 chunk +2 lines, -2 lines 0 comments Download
M protoc-gen-go/testdata/my_test/test.proto View 1 1 chunk +1 line, -0 lines 0 comments Download
M protoc-gen-go/testdata/my_test/test.pb.go View 1 1 chunk +1 line, -1 line 0 comments Download
M protoc-gen-go/testdata/my_test/test.pb.go.golden View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6
dsymonds
Hello r (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/goprotobuf
10 years, 9 months ago (2013-07-26 01:58:56 UTC) #1
r
doesn't the README need updating?
10 years, 9 months ago (2013-07-26 03:31:29 UTC) #2
dsymonds
On 26 July 2013 13:31, <r@golang.org> wrote: > doesn't the README need updating? The README ...
10 years, 9 months ago (2013-07-26 04:12:15 UTC) #3
r
LGTM although maybe at least the landing page in code.google.com/p should say something
10 years, 9 months ago (2013-07-26 06:04:31 UTC) #4
dsymonds
*** Submitted as https://code.google.com/p/goprotobuf/source/detail?r=b2329caf408c *** goprotobuf: Switch to using protobuf-2.5.0 as the baseline. Regenerating descriptor.pb.go ...
10 years, 9 months ago (2013-07-26 06:43:48 UTC) #5
dsymonds
10 years, 9 months ago (2013-07-26 06:44:26 UTC) #6
On 26 July 2013 16:04,  <r@golang.org> wrote:

> although maybe at least the landing page in code.google.com/p should say
> something

Actually it did. It said "you must be running version 2.3 or higher",
so I just updated that.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b