Issue 11889044: code review 11889044: goprotobuf: Present comments in .proto files in the gen...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 11889044: code review 11889044: goprotobuf: Present comments in .proto files in the gen... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 2 months ago by dsymonds

Modified:
12 years, 2 months ago

Reviewers:
r

CC:
r, golang-dev

Visibility:
Public.

Description

goprotobuf: Present comments in .proto files in the generated .pb.go. This doesn't use every comment, but just the ones that I thought would be most useful to someone reading the generated code, namely those attached to these things: - messages - message fields - enums - enum values

Patch Set 1 #

Patch Set 2 : diff -r b2329caf408c https://code.google.com/p/goprotobuf #

Patch Set 3 : diff -r b2329caf408c https://code.google.com/p/goprotobuf #

Patch Set 4 : diff -r b2329caf408c https://code.google.com/p/goprotobuf #

Created: 12 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+657 lines, -183 lines)			Patch
M	proto/testdata/test.pb.go	View	1	11 chunks	+119 lines, -93 lines	0 comments	Download
M	protoc-gen-go/descriptor/descriptor.pb.go	View	1	23 chunks	+345 lines, -66 lines	0 comments	Download
M	protoc-gen-go/generator/generator.go	View	1	15 chunks	+96 lines, -14 lines	0 comments	Download
M	protoc-gen-go/plugin/plugin.pb.go	View	1	3 chunks	+79 lines, -4 lines	0 comments	Download
M	protoc-gen-go/testdata/my_test/test.proto	View	1	2 chunks	+2 lines, -0 lines	0 comments	Download
M	protoc-gen-go/testdata/my_test/test.pb.go	View	1	3 chunks	+8 lines, -3 lines	0 comments	Download
M	protoc-gen-go/testdata/my_test/test.pb.go.golden	View	1	3 chunks	+8 lines, -3 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

dsymonds

Hello r (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/goprotobuf

12 years, 2 months ago (2013-07-26 06:52:21 UTC) #1

dsymonds

12 years, 2 months ago (2013-07-26 09:20:26 UTC) #3

*** Submitted as
https://code.google.com/p/goprotobuf/source/detail?r=4daa80899462 ***

goprotobuf: Present comments in .proto files in the generated .pb.go.

This doesn't use every comment, but just the ones that I thought
would be most useful to someone reading the generated code, namely
those attached to these things:
        - messages
        - message fields
        - enums
        - enum values

R=r
CC=golang-dev
https://codereview.appspot.com/11889044

Expand All Messages | Collapse All Messages