Issue 11879045: code review 11879045: runtime: handle runtime.Goexit during init

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 11879045: code review 11879045: runtime: handle runtime.Goexit during init (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 11 months ago by rsc

Modified:
11 years, 11 months ago

Reviewers:
dsymonds, dvyukov

CC:
golang-dev, dsymonds, dvyukov

Visibility:
Public.

Description

runtime: handle runtime.Goexit during init Fixes issue 5963.

Patch Set 1 #

Patch Set 2 : diff -r b9ee7a3df1c9 https://code.google.com/p/go/ #

Patch Set 3 : diff -r b9ee7a3df1c9 https://code.google.com/p/go/ #

Patch Set 4 : diff -r 9d89d3ed8922 https://code.google.com/p/go/ #

Created: 11 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+68 lines, -0 lines)			Patch
	M	src/pkg/runtime/proc.c	View	1 2	2 chunks	+18 lines, -0 lines	0 comments	Download
	A	test/fixedbugs/issue5963.go	View	1 2	1 chunk	+50 lines, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

rsc

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/

11 years, 11 months ago (2013-07-26 03:52:21 UTC) #1

dvyukov

LGTM I can't think of any reasonable use case for this, though

11 years, 11 months ago (2013-07-26 10:02:26 UTC) #3

rsc

On Fri, Jul 26, 2013 at 6:02 AM, <dvyukov@google.com> wrote: > LGTM > I can't ...

11 years, 11 months ago (2013-07-26 17:52:33 UTC) #4

rsc

11 years, 11 months ago (2013-07-26 17:54:46 UTC) #5

*** Submitted as https://code.google.com/p/go/source/detail?r=94668c624b84 ***

runtime: handle runtime.Goexit during init

Fixes issue 5963.

R=golang-dev, dsymonds, dvyukov
CC=golang-dev
https://codereview.appspot.com/11879045

Expand All Messages | Collapse All Messages