Issue 11877043: Charm model parsing fix

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 11877043: Charm model parsing fix

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 9 months ago by jeff.pihach

Modified:
10 years, 9 months ago

Reviewers:
benjamin.saller, mp+177058

Visibility:
Public.

Description

Charm model parsing fix This branch fixes an issue that caused the charm settings to not appear when running rapi. It was due to a difference between where the options were stored between the new and old charm models. https://code.launchpad.net/~hatch/juju-gui/charm-fix-0.8.1/+merge/177058 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Charm model parsing fix #

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+54 lines, -2 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	app/models/charm.js	View	1 chunk	+8 lines, -1 line	0 comments	Download
M	test/test_model.js	View	1 chunk	+44 lines, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

benjamin.saller

LGTM Not sure if you strictly need the delete there but I assume you've checked ...

10 years, 9 months ago (2013-07-25 22:21:34 UTC) #2

jeff.pihach

10 years, 9 months ago (2013-07-25 22:29:16 UTC) #3

*** Submitted:

Charm model parsing fix

This branch fixes an issue that caused the charm settings to
not appear when running rapi. It was due to a difference between
where the options were stored between the new and old charm models.

R=benjamin.saller
CC=
https://codereview.appspot.com/11877043

Expand All Messages | Collapse All Messages