Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(184)

Issue 11874043: code review 11874043: crypto/des: faster block expansion. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 3 months ago by remyoudompheng
Modified:
4 years, 3 months ago
Reviewers:
rsc, bradfitz
CC:
golang-dev, agl, bradfitz, rsc
Visibility:
Public.

Description

crypto/des: faster block expansion. On amd64: benchmark old ns/op new ns/op delta BenchmarkEncrypt 6170 3593 -41.77% BenchmarkDecrypt 6209 3564 -42.60% benchmark old MB/s new MB/s speedup BenchmarkEncrypt 1.30 2.23 1.72x BenchmarkDecrypt 1.29 2.24 1.74x Update issue 4299.

Patch Set 1 #

Patch Set 2 : diff -r b9ee7a3df1c9 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r b9ee7a3df1c9 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r b9ee7a3df1c9 https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r b9ee7a3df1c9 https://go.googlecode.com/hg/ #

Patch Set 6 : diff -r 6d555b7f39bd https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -12 lines) Patch
M src/pkg/crypto/des/block.go View 1 4 2 chunks +13 lines, -1 line 0 comments Download
M src/pkg/crypto/des/const.go View 1 1 chunk +0 lines, -11 lines 0 comments Download
M src/pkg/crypto/des/des_test.go View 1 1 chunk +28 lines, -0 lines 0 comments Download

Messages

Total messages: 7
remyoudompheng
Hello golang-dev@googlegroups.com, agl@chromium.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
4 years, 3 months ago (2013-07-25 21:50:49 UTC) #1
remyoudompheng
See the 6g assembly for expandBlock: --- prog list "expandBlock" --- 0284 (block.go:68) TEXT expandBlock+0(SB),$0-16 ...
4 years, 3 months ago (2013-07-25 21:52:33 UTC) #2
bradfitz
LGTM Nice. Verified the functions produce equivalent output for all inputs, too. On Thu, Jul ...
4 years, 3 months ago (2013-07-26 00:58:28 UTC) #3
rsc
LGTM
4 years, 3 months ago (2013-07-26 02:51:34 UTC) #4
rsc
Do you know why it flushes block to memory so often?
4 years, 3 months ago (2013-07-26 03:04:31 UTC) #5
remyoudompheng
On 2013/07/26 03:04:31, rsc wrote: > Do you know why it flushes block to memory ...
4 years, 3 months ago (2013-07-26 07:00:02 UTC) #6
remyoudompheng
4 years, 3 months ago (2013-07-26 07:10:52 UTC) #7
*** Submitted as https://code.google.com/p/go/source/detail?r=654ca7de0282 ***

crypto/des: faster block expansion.

On amd64:

benchmark           old ns/op    new ns/op    delta
BenchmarkEncrypt         6170         3593  -41.77%
BenchmarkDecrypt         6209         3564  -42.60%

benchmark            old MB/s     new MB/s  speedup
BenchmarkEncrypt         1.30         2.23    1.72x
BenchmarkDecrypt         1.29         2.24    1.74x

Update issue 4299.

R=golang-dev, agl, bradfitz, rsc
CC=golang-dev
https://codereview.appspot.com/11874043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld c59f3c4