Issue 11849043: Fix FF problem when cookies are disabled

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 11849043: Fix FF problem when cookies are disabled

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 9 months ago by gary.poster

Modified:
10 years, 9 months ago

Reviewers:
benjamin.saller, mp+177002, matthew.scott

Visibility:
Public.

Description

Fix FF problem when cookies are disabled When cookies are disabled in FF, sessionStorage is disabled. When sessionStorage is disabled, it just crashes with a security exception. This works around the issue. https://code.launchpad.net/~gary/juju-gui/support-no-cookies/+merge/177002 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Fix FF problem when cookies are disabled #

Patch Set 3 : Fix FF problem when cookies are disabled #

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+117 lines, -4 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	app/store/env/base.js	View	4 chunks	+52 lines, -3 lines	0 comments	Download
M	test/test_env.js	View	2 chunks	+63 lines, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

gary.poster

10 years, 9 months ago (2013-07-25 18:02:42 UTC) #4

*** Submitted:

Fix FF problem when cookies are disabled

When cookies are disabled in FF, sessionStorage is disabled.  When
sessionStorage is disabled, it just crashes with a security exception.  This
works around the issue.

R=matthew.scott, benjamin.saller
CC=
https://codereview.appspot.com/11849043

Expand All Messages | Collapse All Messages