Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(433)

Issue 118480046: code review 118480046: liblink: encode MOVBQZX as MOVZBL instead of MOVZBQ (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 7 months ago by ruiu
Modified:
10 years, 7 months ago
Reviewers:
rsc
CC:
golang-codereviews, gobot, rsc
Visibility:
Public.

Description

liblink: encode MOVBQZX as MOVZBL instead of MOVZBQ

Patch Set 1 #

Patch Set 2 : code review 118480046: liblink: better MOVZX encoding #

Patch Set 3 : diff -r 71a2dfec0640 https://code.google.com/p/go #

Patch Set 4 : diff -r 6b696a34e0af https://code.google.com/p/go #

Patch Set 5 : diff -r 4dff6ec65b25 https://code.google.com/p/go #

Patch Set 6 : diff -r 13057b322411 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/liblink/asm6.c View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6
ruiu
Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
10 years, 7 months ago (2014-08-04 03:24:43 UTC) #1
gobot
R=rsc@golang.org (assigned by r@golang.org)
10 years, 7 months ago (2014-08-05 15:40:11 UTC) #2
rsc
not lgtm The MOVBQ change is okay, but the others are not safe. They change ...
10 years, 7 months ago (2014-08-06 03:57:27 UTC) #3
ruiu
Thank you for reviewing. I agree -- this CL changes the meaning fo *SX instructions ...
10 years, 7 months ago (2014-08-06 04:26:59 UTC) #4
rsc
LGTM
10 years, 7 months ago (2014-08-06 04:31:15 UTC) #5
ruiu
10 years, 7 months ago (2014-08-06 04:38:43 UTC) #6
*** Submitted as https://code.google.com/p/go/source/detail?r=14d4d642c00e ***

liblink: encode MOVBQZX as MOVZBL instead of MOVZBQ

LGTM=rsc
R=golang-codereviews, gobot, rsc
CC=golang-codereviews
https://codereview.appspot.com/118480046
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b