Removes the old API from the Charmview

Removes the old API from the Charmview

-Replaces use of the old API and loadByPath with the new API and charm.
-Removes last_change from both models, as no such thing exists in the API;
replaces it by adding recent_commits and associated logic to old Charm model.
-CharmView now creates last_change data from the recent_commits. There's an
argument to be had for refactoring the template/view to properly use the charm
attrs, but as charmview will be destroyed once we have the new inspector, it's
not worth the effort.
-Assorted drive by fixes.
-Test updates.

https://code.launchpad.net/~jcsackett/juju-gui/remove-old-api-charm-model/+merge/176998

(do not edit description out of merge proposal)

[j.c.sackett, 2013-07-25 17:04:02]

Please take a look.

[jeff.pihach, 2013-07-25 17:21:06]

LGTM with trivial and a quick testing q

https://codereview.appspot.com/11845043/diff/1/app/models/charm.js
File app/models/charm.js (right):

https://codereview.appspot.com/11845043/diff/1/app/models/charm.js#newcode316
app/models/charm.js:316: valueFn: function() {
you can ditch the wrapper function here and just go

valueFn: this._loadRecentCommits

https://codereview.appspot.com/11845043/diff/1/test/test_charm_view.js
File test/test_charm_view.js (right):

https://codereview.appspot.com/11845043/diff/1/test/test_charm_view.js#newcod...
test/test_charm_view.js:211: var view = new CharmView({
should this view not be destroyed after the test? I see that it isn't in any
others in this suite either.

[j.c.sackett, 2013-07-25 17:48:29]

> valueFn: this._loadRecentCommits

Actually, doing that causes test to fail.

> test/test_charm_view.js:211: var view = new CharmView({
> should this view not be destroyed after the test? I see that it isn't in any
> others in this suite either.

Done.

[j.c.sackett, 2013-07-25 18:09:06]

Please take a look.

[rharding, 2013-07-26 15:06:31]

LGTM though I don't get how the tests work without calling .render().

https://codereview.appspot.com/11845043/diff/8001/test/test_charm_view.js
File test/test_charm_view.js (right):

https://codereview.appspot.com/11845043/diff/8001/test/test_charm_view.js#new...
test/test_charm_view.js:160: //render?
huh, we don't call render on the View? Then we check the container below? This
works?

[j.c.sackett, 2013-07-26 20:12:54]

*** Submitted:

Removes the old API from the Charmview

-Replaces use of the old API and loadByPath with the new API and charm.
-Removes last_change from both models, as no such thing exists in the API;
replaces it by adding recent_commits and associated logic to old Charm model.
-CharmView now creates last_change data from the recent_commits. There's an
argument to be had for refactoring the template/view to properly use the charm
attrs, but as charmview will be destroyed once we have the new inspector, it's
not worth the effort.
-Assorted drive by fixes.
-Test updates.

R=jeff.pihach, rharding
CC=
https://codereview.appspot.com/11845043