Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(553)

Issue 11844043: use chosen for the "select" edit widget

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 10 months ago by xiaq
Modified:
10 years, 9 months ago
Reviewers:
thomas.j.waldmann, Thomas.J.Waldmann
Visibility:
Public.

Description

use chosen for the "select" edit widget

Patch Set 1 #

Total comments: 4

Patch Set 2 : put Chosen dependency after jquery-related stuff #

Patch Set 3 : a bit reorder... #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -1 line) Patch
M MoinMoin/templates/base.html View 2 chunks +3 lines, -0 lines 0 comments Download
M MoinMoin/templates/common.js View 1 chunk +5 lines, -0 lines 0 comments Download
M MoinMoin/templates/forms.html View 1 chunk +1 line, -1 line 0 comments Download
M setup.py View 1 1 chunk +1 line, -0 lines 0 comments Download
M wikiconfig.py View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5
xiaq
Looks like this: https://www.dropbox.com/s/c0x6mm4ahl79vc7/chosen.png
10 years, 10 months ago (2013-07-25 16:45:52 UTC) #1
Thomas.J.Waldmann
https://codereview.appspot.com/11844043/diff/1/MoinMoin/templates/base.html File MoinMoin/templates/base.html (right): https://codereview.appspot.com/11844043/diff/1/MoinMoin/templates/base.html#newcode81 MoinMoin/templates/base.html:81: <script src="{{ url_for('serve.files', name='chosen', filename='chosen.jquery.min.js') }}"></script> they use different ...
10 years, 10 months ago (2013-07-25 16:52:27 UTC) #2
xiaq
https://codereview.appspot.com/11844043/diff/1/MoinMoin/templates/base.html File MoinMoin/templates/base.html (right): https://codereview.appspot.com/11844043/diff/1/MoinMoin/templates/base.html#newcode81 MoinMoin/templates/base.html:81: <script src="{{ url_for('serve.files', name='chosen', filename='chosen.jquery.min.js') }}"></script> On 2013/07/25 16:52:27, ...
10 years, 10 months ago (2013-07-25 17:02:45 UTC) #3
Thomas.J.Waldmann
> Chosen is also available in a Prototype version, hence chosen.jquery.min.js. Ah, ok. > https://codereview.appspot.com/11844043/diff/1/wikiconfig.py#newcode73 ...
10 years, 10 months ago (2013-07-25 17:17:12 UTC) #4
xiaq
10 years, 9 months ago (2013-07-26 02:49:43 UTC) #5
On 2013/07/25 17:17:12, Thomas.J.Waldmann wrote:
> > Chosen is also available in a Prototype version, hence chosen.jquery.min.js.
> 
> Ah, ok.
> 
> > https://codereview.appspot.com/11844043/diff/1/wikiconfig.py#newcode73
> > wikiconfig.py:73: 'chosen',
> > On 2013/07/25 16:52:27, Thomas.J.Waldmann wrote:
> > > if it is jquery-related, move it below the other jquery stuff.
> > 
> > ok, but i need to point out that the ordering is not consistent with that in
> > setup.py - in setup.py bootstrap (which requires jquery) appears above
jquery.
> > fix that (in another cs)?
> 
> Maybe the order in setup.py is alphabetical?
> 

Not really. 'XStatic-AnyWikiDraw>=0.14.2', appears near the end instead of
before XStatic-Bootstrap.

It makes sense to keep the two ordering consistent, and I suppose that putting
both in alphabetical order is just much easier.

> The order of the stuff served in wikiconfig.py is rather grouped by topic.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b