GUI server supports serving GUI tests.

GUI server supports serving GUI tests.

Added support for serving GUI unit tests
from the Tornado server if the --servetest 
parameter is passed.

Also added support for the "ssl-cert-path"
option: the path where the SSL key and cert 
files are stored.

Tests:
Run `make unittest` from the branch root.

https://code.launchpad.net/~frankban/charms/precise/juju-gui/server-serve-tests/+merge/176985

(do not edit description out of merge proposal)

[frankban, 2013-07-25 15:57:00]

Please take a look.

[teknico, 2013-07-25 16:36:28]

LGTM, simple and sweet. One trivial.

https://codereview.appspot.com/11841043/diff/1/server/guiserver/manage.py
File server/guiserver/manage.py (right):

https://codereview.appspot.com/11841043/diff/1/server/guiserver/manage.py#new...
server/guiserver/manage.py:104: help='The Juju GUI tests path. If not provided,
tests are not served')
Add full stop at the end.

[frankban, 2013-07-25 16:44:07]

Please take a look.

https://codereview.appspot.com/11841043/diff/1/server/guiserver/manage.py
File server/guiserver/manage.py (right):

https://codereview.appspot.com/11841043/diff/1/server/guiserver/manage.py#new...
server/guiserver/manage.py:104: help='The Juju GUI tests path. If not provided,
tests are not served')
On 2013/07/25 16:36:28, teknico wrote:
> Add full stop at the end.

Done.

[gary.poster, 2013-07-26 00:38:47]

LGTM.  Wondered about a test to show that test serving is enabled with flag. 
Would be nice, but not required.

[frankban, 2013-07-26 09:25:38]

On 2013/07/26 00:38:47, gary.poster wrote:
> LGTM.  Wondered about a test to show that test serving is enabled with flag. 
> Would be nice, but not required.

You are right: the apps module now includes enough logic to deserve its own test
file.
Added test_apps.py with a bunch of tests for the server and redirector apps.
Thank you!

[frankban, 2013-07-26 09:26:13]

Please take a look.

[teknico, 2013-07-26 09:39:01]

LGTM again, fantastic, thank you.

[frankban, 2013-07-26 09:46:14]

Please take a look.

[frankban, 2013-07-26 13:12:18]

*** Submitted:

GUI server supports serving GUI tests.

Added support for serving GUI unit tests
from the Tornado server if the --servetest 
parameter is passed.

Also added support for the "ssl-cert-path"
option: the path where the SSL key and cert 
files are stored.

Tests:
Run `make unittest` from the branch root.

R=teknico, gary.poster
CC=
https://codereview.appspot.com/11841043