Issue 118410043: code review 118410043: bufio: fix rot13Reader bug in test

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 118410043: code review 118410043: bufio: fix rot13Reader bug in test (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 9 months ago by ruiu

Modified:
10 years, 9 months ago

Reviewers:
gobot, bradfitz

CC:
golang-codereviews, bradfitz

Visibility:
Public.

Description

bufio: fix rot13Reader bug in test

Patch Set 1 #

Patch Set 2 : code review 118410043: bufio: fix rot13Reader bug in test #

Patch Set 3 : diff -r 6125ea2b1dbf https://code.google.com/p/go #

Patch Set 4 : diff -r 27e6707fe68d https://code.google.com/p/go #

Patch Set 5 : diff -r aa436887421e https://code.google.com/p/go #

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -4 lines)			Patch
	M	src/pkg/bufio/bufio_test.go	View		2 chunks	+1 line, -4 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

ruiu

Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go

10 years, 9 months ago (2014-07-30 00:38:20 UTC) #1

ruiu

*** Submitted as https://code.google.com/p/go/source/detail?r=98de2cb860a0 *** bufio: fix rot13Reader bug in test LGTM=bradfitz R=golang-codereviews, bradfitz CC=golang-codereviews ...

10 years, 9 months ago (2014-07-30 00:56:30 UTC) #3

gobot

This CL appears to have broken the netbsd-amd64-bsiegert builder. See http://build.golang.org/log/9ec42ece2ecf72951c347322afab85805a3bf488

10 years, 9 months ago (2014-07-30 03:03:03 UTC) #4

ruiu

10 years, 9 months ago (2014-07-30 03:18:28 UTC) #5

Unrelated.


On Tue, Jul 29, 2014 at 8:03 PM, <gobot@golang.org> wrote:

> This CL appears to have broken the netbsd-amd64-bsiegert builder.
> See http://build.golang.org/log/9ec42ece2ecf72951c347322afab85805a3bf488
>
> https://codereview.appspot.com/118410043/
>

Expand All Messages | Collapse All Messages