Issue 11831043: Updates charm view to use Charm model.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 11831043: Updates charm view to use Charm model.

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 9 months ago by j.c.sackett

Modified:
10 years, 9 months ago

Reviewers:
jeff.pihach, matthew.scott, mp+176938

Visibility:
Public.

Description

Updates charm view to use Charm model. To make it easier to clean up and phase out the old API, the charm views (which have previously worked on parsed JSON) are updated to use the Charm model and the old API. This makes it much easier to translate to the new API, and further down the road, the BrowserCharm model. -Charm view uses Charm model and loadByPath -CharmCollection view, which appears to be unused now that the old search is gone, is deleted. https://code.launchpad.net/~jcsackett/juju-gui/use-models-everywhere/+merge/176938 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Updates charm view to use Charm model. #

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+27 lines, -277 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	app/app.js	View	3 chunks	+1 line, -21 lines	0 comments	Download
M	app/views/charm.js	View	7 chunks	+23 lines, -97 lines	0 comments	Download
M	test/index.html	View	1 chunk	+0 lines, -1 line	0 comments	Download
D	test/test_charm_collection_view.js	View	1 chunk	+0 lines, -155 lines	0 comments	Download
M	test/test_charm_view.js	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	test/test_subapp_app_extension.js	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	undocumented	View	1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

j.c.sackett

10 years, 9 months ago (2013-07-25 14:41:04 UTC) #4

*** Submitted:

Updates charm view to use Charm model.

To make it easier to clean up and phase out the old API, the charm views (which
have previously worked on parsed JSON) are updated to use the Charm model and
the old API. This makes it much easier to translate to the new API, and further
down the road, the BrowserCharm model.
-Charm view uses Charm model and loadByPath
-CharmCollection view, which appears to be unused now that the old search is
gone, is deleted.

R=matthew.scott, jeff.pihach
CC=
https://codereview.appspot.com/11831043

Expand All Messages | Collapse All Messages