code review 118020043: make.bat: do not exit builder on successful completion ...

make.bat: do not exit builder on successful completion of make.bat (fixes build)

[brainman, 2014-07-21 00:59:02]

Hello golang-codereviews@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[brainman, 2014-07-21 01:02:43]

# grep make.bat all.bat race.bat
all.bat:if exist make.bat goto ok
all.bat:call make.bat --no-banner --no-local
race.bat:if exist make.bat goto ok
race.bat:call make.bat --dist-tool >NUL
race.bat:call make.bat --no-banner --no-local

At this moment build ends at the end of call to make.bat (successful or failed).
So all.bat exits after first call to make.bat (it builds commands and packages,
but no testing is performed), similar race.bat exist after first call to
make.bat (it builds dist tool, but no build or testing is performed).

No wonder windows builders are suddenly quick.

Alex

[dvyukov, 2014-07-21 06:09:58]

LGTM

[brainman, 2014-07-21 06:29:46]

*** Submitted as https://code.google.com/p/go/source/detail?r=82cbf874e066 ***

make.bat: do not exit builder on successful completion of make.bat (fixes build)

LGTM=dvyukov
R=golang-codereviews, dvyukov
CC=golang-codereviews
https://codereview.appspot.com/118020043