Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(424)

Issue 118020043: code review 118020043: make.bat: do not exit builder on successful completion ... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 8 months ago by brainman
Modified:
10 years, 8 months ago
Reviewers:
dvyukov
CC:
golang-codereviews, dvyukov
Visibility:
Public.

Description

make.bat: do not exit builder on successful completion of make.bat (fixes build)

Patch Set 1 #

Patch Set 2 : diff -r bbddc25284e9 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r bbddc25284e9 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r bbddc25284e9 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/make.bat View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4
brainman
Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
10 years, 8 months ago (2014-07-21 00:59:02 UTC) #1
brainman
# grep make.bat all.bat race.bat all.bat:if exist make.bat goto ok all.bat:call make.bat --no-banner --no-local race.bat:if ...
10 years, 8 months ago (2014-07-21 01:02:43 UTC) #2
dvyukov
LGTM
10 years, 8 months ago (2014-07-21 06:09:58 UTC) #3
brainman
10 years, 8 months ago (2014-07-21 06:29:46 UTC) #4
*** Submitted as https://code.google.com/p/go/source/detail?r=82cbf874e066 ***

make.bat: do not exit builder on successful completion of make.bat (fixes build)

LGTM=dvyukov
R=golang-codereviews, dvyukov
CC=golang-codereviews
https://codereview.appspot.com/118020043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b