code review 117950044: vet: teach vet about nacl.

vet: LEA* opcodes don't need to have matching length source and destination.

[khr, 2014-07-18 19:32:49]

Hello golang-codereviews@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go.tools

[khr1, 2014-07-21 21:50:20]

Russ, could you take a look?



On Fri, Jul 18, 2014 at 12:32 PM, <khr@golang.org> wrote:

> Reviewers: golang-codereviews,
>
> Message:
> Hello golang-codereviews@googlegroups.com,
>
> I'd like you to review this change to
> https://code.google.com/p/go.tools
>
>
> Description:
> vet: teach vet about nacl.
>
> Also teach it that LEA* opcodes don't need
> to have matching length source and destination.
>
> Please review this at https://codereview.appspot.com/117950044/
>
> Affected files (+15, -4 lines):
>   M cmd/vet/asmdecl.go
>
>
> Index: cmd/vet/asmdecl.go
> ===================================================================
> --- a/cmd/vet/asmdecl.go
> +++ b/cmd/vet/asmdecl.go
> @@ -33,6 +33,7 @@
>         name      string
>         ptrSize   int
>         intSize   int
> +       maxAlign  int
>         bigEndian bool
>  }
>
> @@ -55,14 +56,16 @@
>  }
>
>  var (
> -       asmArch386   = asmArch{"386", 4, 4, false}
> -       asmArchArm   = asmArch{"arm", 4, 4, false}
> -       asmArchAmd64 = asmArch{"amd64", 8, 8, false}
> +       asmArch386      = asmArch{"386", 4, 4, 4, false}
> +       asmArchArm      = asmArch{"arm", 4, 4, 4, false}
> +       asmArchAmd64    = asmArch{"amd64", 8, 8, 8, false}
> +       asmArchAmd64p32 = asmArch{"amd64p32", 4, 4, 8, false}
>
>         arches = []*asmArch{
>                 &asmArch386,
>                 &asmArchArm,
>                 &asmArchAmd64,
> +               &asmArchAmd64p32,
>         }
>  )
>
> @@ -403,7 +406,7 @@
>                 offset = 0
>                 addParams(decl.Type.Params.List)
>                 if decl.Type.Results != nil && len(decl.Type.Results.List)
> > 0 {
> -                       offset += -offset & (arch.ptrSize - 1)
> +                       offset += -offset & (arch.maxAlign - 1)
>                         addParams(decl.Type.Results.List)
>                 }
>                 fn.size = offset
> @@ -438,6 +441,14 @@
>                 src = 2
>         case "arm.MOVB", "arm.MOVBU":
>                 src = 1
> +       // LEA* opcodes don't really read the second arg.
> +       // They just take the address of it.
> +       case "386.LEAL":
> +               dst = 4
> +       case "amd64.LEAQ":
> +               dst = 8
> +       case "amd64p32.LEAL":
> +               dst = 4
>         default:
>                 if fn.arch.name == "386" || fn.arch.name == "amd64" {
>                         if strings.HasPrefix(op, "F") &&
> (strings.HasSuffix(op, "D") || strings.HasSuffix(op, "DP")) {
>
>
>

[rsc, 2014-07-22 01:58:55]

LGTM for lea

Please hg sync. I added amd64p32 in CL 93410045 (and you sent it again in
CL 109060043).

[khr, 2014-07-22 04:15:43]

*** Submitted as
https://code.google.com/p/go/source/detail?r=490f3b0c0dad&repo=tools ***

vet: LEA* opcodes don't need to have matching length source and destination.

LGTM=rsc
R=golang-codereviews, khr, rsc
CC=golang-codereviews
https://codereview.appspot.com/117950044