Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(367)

Issue 117920043: code review 117920043: cmd/addr2line, cmd/objdump: fix on amd64 Plan 9 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 8 months ago by 0intro
Modified:
10 years, 8 months ago
Reviewers:
aram, mischief, ality
CC:
rsc, mischief, aram, ality, golang-codereviews, jas
Visibility:
Public.

Description

cmd/addr2line, cmd/objdump: fix on amd64 Plan 9 Fix virtual address of the start of the text segment on amd64 Plan 9. This issue has been partially fixed in cmd/add2line, as part of CL 106460044, but we forgot to report the change to cmd/objdump. In the meantime, we also fixed the textStart address in both cmd/add2line and cmd/objdump.

Patch Set 1 #

Patch Set 2 : diff -r f4c58e179e40 https://code.google.com/p/go #

Patch Set 3 : diff -r f4c58e179e40 https://code.google.com/p/go #

Total comments: 4

Patch Set 4 : diff -r f749e3111252 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -16 lines) Patch
M src/cmd/addr2line/main.go View 2 chunks +3 lines, -6 lines 0 comments Download
M src/cmd/objdump/main.go View 3 chunks +3 lines, -10 lines 0 comments Download

Messages

Total messages: 9
0intro
Hello rsc (cc: ality, aram, golang-codereviews@googlegroups.com, jas, mischief), I'd like you to review this change ...
10 years, 8 months ago (2014-07-18 09:15:12 UTC) #1
mischief
this is is a small improvement, as now the file:lineno shows up. but the symbols ...
10 years, 8 months ago (2014-07-18 09:30:18 UTC) #2
aram
LGTM
10 years, 8 months ago (2014-07-18 10:13:00 UTC) #3
ality
LGTM after changes noted below https://codereview.appspot.com/117920043/diff/40001/src/cmd/objdump/main.go File src/cmd/objdump/main.go (right): https://codereview.appspot.com/117920043/diff/40001/src/cmd/objdump/main.go#newcode368 src/cmd/objdump/main.go:368: sym, err := findPlan9Symbol(obj, ...
10 years, 8 months ago (2014-07-18 23:51:50 UTC) #4
0intro
Thanks. I've also reported the changes to cmd/addr2line. https://codereview.appspot.com/117920043/diff/40001/src/cmd/objdump/main.go File src/cmd/objdump/main.go (right): https://codereview.appspot.com/117920043/diff/40001/src/cmd/objdump/main.go#newcode368 src/cmd/objdump/main.go:368: sym, ...
10 years, 8 months ago (2014-07-19 00:12:04 UTC) #5
ality
0intro@gmail.com once said: > Thanks. I've also reported the changes to cmd/addr2line. No problem. I ...
10 years, 8 months ago (2014-07-19 00:39:24 UTC) #6
mischief
LGTM cmd/objdump is passing now
10 years, 8 months ago (2014-07-19 07:34:07 UTC) #7
aram
LGTM
10 years, 8 months ago (2014-07-19 09:15:14 UTC) #8
aram
10 years, 8 months ago (2014-07-19 09:16:40 UTC) #9
*** Submitted as https://code.google.com/p/go/source/detail?r=66c3664bd245 ***

cmd/addr2line, cmd/objdump: fix on amd64 Plan 9

Fix virtual address of the start of the text segment
on amd64 Plan 9.

This issue has been partially fixed in cmd/add2line,
as part of CL 106460044, but we forgot to report the
change to cmd/objdump.

In the meantime, we also fixed the textStart address
in both cmd/add2line and cmd/objdump.

LGTM=aram, ality, mischief
R=rsc, mischief, aram, ality
CC=golang-codereviews, jas
https://codereview.appspot.com/117920043

Committer: Aram Hăvărneanu <aram@mgk.ro>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b