Issue 117810045: code review 117810045: ogle/program/server: print maps

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 117810045: code review 117810045: ogle/program/server: print maps (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 9 months ago by r

Modified:
9 years, 9 months ago

Reviewers:
nigeltao

CC:
nigeltao

Visibility:
Public.

Description

ogle/program/server: print maps Add code to pretty-print maps. Depends on the internals of the map implementation but there's no way around that.

Patch Set 2 : diff -r fe930b89c877 https://code.google.com/p/ogle #

Total comments: 4

Patch Set 3 : diff -r fe930b89c877 https://code.google.com/p/ogle #

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+111 lines, -6 lines)			Patch
	M	arch/arch.go	View		1 chunk	+24 lines, -0 lines	0 comments	Download
	M	program/server/print.go	View	1 2	2 chunks	+87 lines, -6 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Hello nigeltao, I'd like you to review this change to https://code.google.com/p/ogle

9 years, 9 months ago (2014-07-15 22:33:38 UTC) #1

nigeltao

LGTM. https://codereview.appspot.com/117810045/diff/20001/program/server/print.go File program/server/print.go (right): https://codereview.appspot.com/117810045/diff/20001/program/server/print.go#newcode312 program/server/print.go:312: count := int(p.arch.Uint(p.tmp[offset : offset+p.arch.PointerSize])) I think that ...

9 years, 9 months ago (2014-07-16 05:19:58 UTC) #2

9 years, 9 months ago (2014-07-16 17:40:11 UTC) #3

*** Submitted as https://code.google.com/p/ogle/source/detail?r=076714627068 ***

ogle/program/server: print maps
Add code to pretty-print maps. Depends on the internals of the map
implementation but there's no way around that.

LGTM=nigeltao
R=nigeltao
https://codereview.appspot.com/117810045

Expand All Messages | Collapse All Messages