Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(821)

Issue 117810045: code review 117810045: ogle/program/server: print maps (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 6 months ago by r
Modified:
7 years, 6 months ago
Reviewers:
nigeltao
CC:
nigeltao
Visibility:
Public.

Description

ogle/program/server: print maps Add code to pretty-print maps. Depends on the internals of the map implementation but there's no way around that.

Patch Set 1 #

Patch Set 2 : diff -r fe930b89c877 https://code.google.com/p/ogle #

Total comments: 4

Patch Set 3 : diff -r fe930b89c877 https://code.google.com/p/ogle #

Unified diffs Side-by-side diffs Delta from patch set Stats (+111 lines, -6 lines) Patch
M arch/arch.go View 1 chunk +24 lines, -0 lines 0 comments Download
M program/server/print.go View 1 2 2 chunks +87 lines, -6 lines 0 comments Download

Messages

Total messages: 3
r
Hello nigeltao, I'd like you to review this change to https://code.google.com/p/ogle
7 years, 6 months ago (2014-07-15 22:33:38 UTC) #1
nigeltao
LGTM. https://codereview.appspot.com/117810045/diff/20001/program/server/print.go File program/server/print.go (right): https://codereview.appspot.com/117810045/diff/20001/program/server/print.go#newcode312 program/server/print.go:312: count := int(p.arch.Uint(p.tmp[offset : offset+p.arch.PointerSize])) I think that ...
7 years, 6 months ago (2014-07-16 05:19:58 UTC) #2
r
7 years, 6 months ago (2014-07-16 17:40:11 UTC) #3
*** Submitted as https://code.google.com/p/ogle/source/detail?r=076714627068 ***

ogle/program/server: print maps
Add code to pretty-print maps. Depends on the internals of the map
implementation but there's no way around that.

LGTM=nigeltao
R=nigeltao
https://codereview.appspot.com/117810045
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b