Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(427)

Issue 117790043: code review 117790043: go/ast: fix walk to handle "for range x" (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 8 months ago by gri
Modified:
10 years, 8 months ago
Reviewers:
rsc
CC:
rsc, golang-codereviews
Visibility:
Public.

Description

go/ast: fix walk to handle "for range x"

Patch Set 1 #

Patch Set 2 : diff -r 29e283742de1 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 59db6f912bf3 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M src/pkg/go/ast/walk.go View 1 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 4
gri
Hello rsc (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/
10 years, 8 months ago (2014-07-14 23:25:15 UTC) #1
gri
Hello rsc@golang.org (cc: golang-codereviews@googlegroups.com), Please take another look.
10 years, 8 months ago (2014-07-14 23:31:36 UTC) #2
rsc
LGTM
10 years, 8 months ago (2014-07-15 00:47:02 UTC) #3
gri
10 years, 8 months ago (2014-07-15 02:14:30 UTC) #4
*** Submitted as https://code.google.com/p/go/source/detail?r=0a7ba4feafc5 ***

go/ast: fix walk to handle "for range x"

LGTM=rsc
R=rsc
CC=golang-codereviews
https://codereview.appspot.com/117790043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b