code review 117680043: dist: fix Plan 9 build

dist: fix Plan 9 build

Since CL 115060044, mkanames declares an empty
array in anames8.c and anames6.c, which is not
valid for the Plan 9 compiler.

char* cnames8[] = {
};

This change makes mkanames not declaring the
cnames array when no C_ constants are found.

[0intro, 2014-08-06 08:57:39]

Hello minux (cc: golang-codereviews@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go

[iant, 2014-08-06 13:10:36]

LGTM

[iant, 2014-08-06 13:11:49]

*** Submitted as https://code.google.com/p/go/source/detail?r=98c597959808 ***

dist: fix Plan 9 build

Since CL 115060044, mkanames declares an empty
array in anames8.c and anames6.c, which is not
valid for the Plan 9 compiler.

char* cnames8[] = {
};

This change makes mkanames not declaring the
cnames array when no C_ constants are found.

LGTM=iant
R=minux, iant
CC=golang-codereviews
https://codereview.appspot.com/117680043

Committer: Ian Lance Taylor <iant@golang.org>

[gobot, 2014-08-06 14:26:04]

This CL appears to have broken the freebsd-amd64-race builder.
See http://build.golang.org/log/08f6845ff56ba26e380d39f678275ed03072ba19

[iant, 2014-08-06 14:31:06]

On Wed, Aug 6, 2014 at 7:26 AM,  <gobot@golang.org> wrote:
> This CL appears to have broken the freebsd-amd64-race builder.
> See http://build.golang.org/log/08f6845ff56ba26e380d39f678275ed03072ba19
>
> https://codereview.appspot.com/117680043/

Interesting failure but it's hard to see how it could be related.

==================
WARNING: DATA RACE
Read by goroutine 61:
  sync.raceRead()
      /usr/local/go/src/pkg/sync/race.go:37 +0x35
  sync.(*WaitGroup).Add()
      /usr/local/go/src/pkg/sync/waitgroup.go:60 +0xbe
  net/http_test.func·189()
     
/usr/home/gopher/racer/work/freebsd-amd64-race-98c597959808/go/src/pkg/net/http/transport_test.go:1074
+0xa6
  net/http.(*Transport).dial()
     
/usr/home/gopher/racer/work/freebsd-amd64-race-98c597959808/go/src/pkg/net/http/transport.go:442
+0xcb
  net/http.(*Transport).dialConn()
     
/usr/home/gopher/racer/work/freebsd-amd64-race-98c597959808/go/src/pkg/net/http/transport.go:496
+0xab
  net/http.func·022()
     
/usr/home/gopher/racer/work/freebsd-amd64-race-98c597959808/go/src/pkg/net/http/transport.go:472
+0x8c

Previous write by goroutine 50:
  sync.raceWrite()
      /usr/local/go/src/pkg/sync/race.go:41 +0x35
  sync.(*WaitGroup).Wait()
      /usr/local/go/src/pkg/sync/waitgroup.go:122 +0x176
  net/http_test.TestTransportConcurrency()
     
/usr/home/gopher/racer/work/freebsd-amd64-race-98c597959808/go/src/pkg/net/http/transport_test.go:1110
+0x6a3
  testing.tRunner()
      /usr/local/go/src/pkg/testing/testing.go:427 +0x10b

Goroutine 61 (running) created at:
  net/http.(*Transport).getConn()
     
/usr/home/gopher/racer/work/freebsd-amd64-race-98c597959808/go/src/pkg/net/http/transport.go:474
+0x334
  net/http.(*Transport).RoundTrip()
     
/usr/home/gopher/racer/work/freebsd-amd64-race-98c597959808/go/src/pkg/net/http/transport.go:201
+0x57e
  net/http.send()
     
/usr/home/gopher/racer/work/freebsd-amd64-race-98c597959808/go/src/pkg/net/http/client.go:195
+0x626
  net/http.(*Client).send()
     
/usr/home/gopher/racer/work/freebsd-amd64-race-98c597959808/go/src/pkg/net/http/client.go:118
+0x1ff
  net/http.(*Client).doFollowingRedirects()
     
/usr/home/gopher/racer/work/freebsd-amd64-race-98c597959808/go/src/pkg/net/http/client.go:343
+0xd27
  net/http.(*Client).Get()
     
/usr/home/gopher/racer/work/freebsd-amd64-race-98c597959808/go/src/pkg/net/http/client.go:275
+0xcd
  net/http_test.func·190()
     
/usr/home/gopher/racer/work/freebsd-amd64-race-98c597959808/go/src/pkg/net/http/transport_test.go:1087
+0x188

Goroutine 50 (finished) created at:
  testing.RunTests()
      /usr/local/go/src/pkg/testing/testing.go:509 +0xb3e
  testing.Main()
      /usr/local/go/src/pkg/testing/testing.go:440 +0xa2
  main.main()
      net/http/_test/_testmain.go:479 +0xdc
==================
PASS
Found 1 data race(s)
FAIL net/http 24.838s

[dvyukov, 2014-08-06 14:50:13]

Ha! It's a real [unrelated] bug. Filed:
https://code.google.com/p/go/issues/detail?id=8483


On Wed, Aug 6, 2014 at 6:31 PM, Ian Lance Taylor <iant@golang.org> wrote:
> On Wed, Aug 6, 2014 at 7:26 AM,  <gobot@golang.org> wrote:
>> This CL appears to have broken the freebsd-amd64-race builder.
>> See http://build.golang.org/log/08f6845ff56ba26e380d39f678275ed03072ba19
>>
>> https://codereview.appspot.com/117680043/
>
> Interesting failure but it's hard to see how it could be related.
>
> ==================
> WARNING: DATA RACE
> Read by goroutine 61:
>   sync.raceRead()
>       /usr/local/go/src/pkg/sync/race.go:37 +0x35
>   sync.(*WaitGroup).Add()
>       /usr/local/go/src/pkg/sync/waitgroup.go:60 +0xbe
>   net/http_test.func·189()
>      
/usr/home/gopher/racer/work/freebsd-amd64-race-98c597959808/go/src/pkg/net/http/transport_test.go:1074
> +0xa6
>   net/http.(*Transport).dial()
>      
/usr/home/gopher/racer/work/freebsd-amd64-race-98c597959808/go/src/pkg/net/http/transport.go:442
> +0xcb
>   net/http.(*Transport).dialConn()
>      
/usr/home/gopher/racer/work/freebsd-amd64-race-98c597959808/go/src/pkg/net/http/transport.go:496
> +0xab
>   net/http.func·022()
>      
/usr/home/gopher/racer/work/freebsd-amd64-race-98c597959808/go/src/pkg/net/http/transport.go:472
> +0x8c
>
> Previous write by goroutine 50:
>   sync.raceWrite()
>       /usr/local/go/src/pkg/sync/race.go:41 +0x35
>   sync.(*WaitGroup).Wait()
>       /usr/local/go/src/pkg/sync/waitgroup.go:122 +0x176
>   net/http_test.TestTransportConcurrency()
>      
/usr/home/gopher/racer/work/freebsd-amd64-race-98c597959808/go/src/pkg/net/http/transport_test.go:1110
> +0x6a3
>   testing.tRunner()
>       /usr/local/go/src/pkg/testing/testing.go:427 +0x10b
>
> Goroutine 61 (running) created at:
>   net/http.(*Transport).getConn()
>      
/usr/home/gopher/racer/work/freebsd-amd64-race-98c597959808/go/src/pkg/net/http/transport.go:474
> +0x334
>   net/http.(*Transport).RoundTrip()
>      
/usr/home/gopher/racer/work/freebsd-amd64-race-98c597959808/go/src/pkg/net/http/transport.go:201
> +0x57e
>   net/http.send()
>      
/usr/home/gopher/racer/work/freebsd-amd64-race-98c597959808/go/src/pkg/net/http/client.go:195
> +0x626
>   net/http.(*Client).send()
>      
/usr/home/gopher/racer/work/freebsd-amd64-race-98c597959808/go/src/pkg/net/http/client.go:118
> +0x1ff
>   net/http.(*Client).doFollowingRedirects()
>      
/usr/home/gopher/racer/work/freebsd-amd64-race-98c597959808/go/src/pkg/net/http/client.go:343
> +0xd27
>   net/http.(*Client).Get()
>      
/usr/home/gopher/racer/work/freebsd-amd64-race-98c597959808/go/src/pkg/net/http/client.go:275
> +0xcd
>   net/http_test.func·190()
>      
/usr/home/gopher/racer/work/freebsd-amd64-race-98c597959808/go/src/pkg/net/http/transport_test.go:1087
> +0x188
>
> Goroutine 50 (finished) created at:
>   testing.RunTests()
>       /usr/local/go/src/pkg/testing/testing.go:509 +0xb3e
>   testing.Main()
>       /usr/local/go/src/pkg/testing/testing.go:440 +0xa2
>   main.main()
>       net/http/_test/_testmain.go:479 +0xdc
> ==================
> PASS
> Found 1 data race(s)
> FAIL net/http 24.838s
>
> --
> You received this message because you are subscribed to the Google Groups
"golang-codereviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
email to golang-codereviews+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.

[minux, 2014-08-06 21:38:43]

Thank you very much David.