state/api(server)/deployer: Addresses, CACert

state/api(server)/deployer: Addresses, CACert

Three calls implemented in the Deployer API
facades (client- and server-side), needed by
the deployer worker: StateAddresses(), APIAddresses(),
and CACert(). They match the same methods found
in state/open.go, except for StateAddresses(), which
corresponds to Addresses(), but was renamed as a
suggestion in the review.

https://code.launchpad.net/~dimitern/juju-core/079-api-addresses-deployer/+merge/176669

(do not edit description out of merge proposal)

[dimitern, 2013-07-24 12:24:46]

Please take a look.

[dimitern, 2013-07-24 12:51:19]

Please take a look.

[rog, 2013-07-24 13:00:59]

LGTM with a couple of suggestions below

https://codereview.appspot.com/11765043/diff/4001/state/api/deployer/deployer.go
File state/api/deployer/deployer.go (right):

https://codereview.appspot.com/11765043/diff/4001/state/api/deployer/deployer...
state/api/deployer/deployer.go:67: err := st.caller.Call("Deployer", "",
"Addresses", nil, &result)
s/Addresses/MongoAddresses/ ?

https://codereview.appspot.com/11765043/diff/4001/state/apiserver/deployer/de...
File state/apiserver/deployer/deployer.go (right):

https://codereview.appspot.com/11765043/diff/4001/state/apiserver/deployer/de...
state/apiserver/deployer/deployer.go:156: func (d *DeployerAPI) APIAddresses()
(params.StringsResult, error) {
just a thought:

func (d *DeployerAPI) APIAddresses() (result params.String, err error) {
    result.Result, err = d.st.APIAddresses()
    return
}

[mue, 2013-07-24 13:17:59]

LGTM, some smaller comments.

https://codereview.appspot.com/11765043/diff/4001/state/api/deployer/deployer.go
File state/api/deployer/deployer.go (right):

https://codereview.appspot.com/11765043/diff/4001/state/api/deployer/deployer...
state/api/deployer/deployer.go:67: err := st.caller.Call("Deployer", "",
"Addresses", nil, &result)
On 2013/07/24 13:00:59, rog wrote:
> s/Addresses/MongoAddresses/ ?

Please no technology in the naming, better StateAddresses.

https://codereview.appspot.com/11765043/diff/4001/state/apiserver/deployer/de...
File state/apiserver/deployer/deployer.go (right):

https://codereview.appspot.com/11765043/diff/4001/state/apiserver/deployer/de...
state/apiserver/deployer/deployer.go:145: func (d *DeployerAPI) Addresses()
(params.StringsResult, error) {
StateAddresses?

[dimitern, 2013-07-24 13:21:31]

Please take a look.

https://codereview.appspot.com/11765043/diff/4001/state/api/deployer/deployer.go
File state/api/deployer/deployer.go (right):

https://codereview.appspot.com/11765043/diff/4001/state/api/deployer/deployer...
state/api/deployer/deployer.go:67: err := st.caller.Call("Deployer", "",
"Addresses", nil, &result)
On 2013/07/24 13:00:59, rog wrote:
> s/Addresses/MongoAddresses/ ?

StateAddresses, as agreed online. This will require changing some interfaces in
the deployer worker in the coming follow-up.

https://codereview.appspot.com/11765043/diff/4001/state/api/deployer/deployer...
state/api/deployer/deployer.go:67: err := st.caller.Call("Deployer", "",
"Addresses", nil, &result)
On 2013/07/24 13:17:59, mue wrote:
> On 2013/07/24 13:00:59, rog wrote:
> > s/Addresses/MongoAddresses/ ?
> 
> Please no technology in the naming, better StateAddresses.

Done.

https://codereview.appspot.com/11765043/diff/4001/state/apiserver/deployer/de...
File state/apiserver/deployer/deployer.go (right):

https://codereview.appspot.com/11765043/diff/4001/state/apiserver/deployer/de...
state/apiserver/deployer/deployer.go:145: func (d *DeployerAPI) Addresses()
(params.StringsResult, error) {
On 2013/07/24 13:17:59, mue wrote:
> StateAddresses?

Done.

https://codereview.appspot.com/11765043/diff/4001/state/apiserver/deployer/de...
state/apiserver/deployer/deployer.go:156: func (d *DeployerAPI) APIAddresses()
(params.StringsResult, error) {
On 2013/07/24 13:00:59, rog wrote:
> just a thought:
> 
> func (d *DeployerAPI) APIAddresses() (result params.String, err error) {
>     result.Result, err = d.st.APIAddresses()
>     return
> }

I prefer the more explicit form, if you don't mind, while keeping the more
descriptive StringsResult type.