|
|
agent/tools: do not embed Binary
I want to serialise Tools as part of the API
and it doesn't read well with an embedded
field (also there's a difference between Go1.0.2
and Go1.1 with embedded fields.
We could just define a Tools.MarshalJSON
method, but I prefer to make Tools marshal
nicely as-is.
I think it actually reads better without the
embedding too.
https://code.launchpad.net/~rogpeppe/juju-core/349-tools-json/+merge/176728
(do not edit description out of merge proposal)
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+138 lines, -136 lines) |
Patch |
 |
A |
[revision details]
|
View
|
|
1 chunk |
+2 lines, -0 lines |
0 comments
|
Download
|
|
M |
agent/tools/diskmanager_test.go
|
View
|
|
3 chunks |
+6 lines, -6 lines |
0 comments
|
Download
|
|
M |
agent/tools/list.go
|
View
|
|
6 chunks |
+19 lines, -19 lines |
0 comments
|
Download
|
|
M |
agent/tools/list_test.go
|
View
|
|
2 chunks |
+5 lines, -5 lines |
0 comments
|
Download
|
|
M |
agent/tools/marshal.go
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
agent/tools/marshal_test.go
|
View
|
|
2 chunks |
+3 lines, -3 lines |
0 comments
|
Download
|
|
M |
agent/tools/storage.go
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
agent/tools/storage_test.go
|
View
|
|
4 chunks |
+4 lines, -4 lines |
0 comments
|
Download
|
|
M |
agent/tools/tools.go
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
agent/tools/tools_test.go
|
View
|
|
6 chunks |
+14 lines, -14 lines |
0 comments
|
Download
|
|
M |
agent/tools/toolsdir.go
|
View
|
|
3 chunks |
+5 lines, -5 lines |
0 comments
|
Download
|
|
M |
cmd/juju/bootstrap.go
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
cmd/juju/status.go
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
cmd/juju/status_test.go
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
cmd/juju/synctools.go
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
cmd/juju/upgradejuju.go
|
View
|
|
1 chunk |
+3 lines, -3 lines |
0 comments
|
Download
|
|
M |
cmd/jujud/agent_test.go
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
cmd/jujud/upgrade.go
|
View
|
|
5 chunks |
+6 lines, -6 lines |
0 comments
|
Download
|
|
M |
cmd/jujud/upgrade_test.go
|
View
|
|
3 chunks |
+5 lines, -5 lines |
0 comments
|
Download
|
|
M |
container/lxc/lxc_test.go
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
environs/cloudinit/cloudinit.go
|
View
|
|
3 chunks |
+3 lines, -3 lines |
0 comments
|
Download
|
|
M |
environs/cloudinit/cloudinit_test.go
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
environs/cloudinit_test.go
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
environs/jujutest/livetests.go
|
View
|
|
5 chunks |
+6 lines, -6 lines |
0 comments
|
Download
|
|
M |
environs/local/environ.go
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
environs/testing/tools.go
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
environs/tools_test.go
|
View
|
|
2 chunks |
+3 lines, -3 lines |
0 comments
|
Download
|
|
M |
state/api/upgrader/upgrader_test.go
|
View
|
|
2 chunks |
+4 lines, -4 lines |
0 comments
|
Download
|
|
M |
state/apiserver/upgrader/upgrader.go
|
View
|
|
3 chunks |
+9 lines, -9 lines |
0 comments
|
Download
|
|
M |
state/apiserver/upgrader/upgrader_test.go
|
View
|
|
2 chunks |
+8 lines, -8 lines |
0 comments
|
Download
|
|
M |
state/machine.go
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
state/machine_test.go
|
View
|
|
2 chunks |
+4 lines, -4 lines |
0 comments
|
Download
|
|
M |
state/state_test.go
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
state/tools_test.go
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
state/unit.go
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
worker/provisioner/lxc-broker_test.go
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
Total messages: 3
|
